[1525] in Moira
Re: proposed changes for adding a new field to User table
daemon@ATHENA.MIT.EDU (Garry Zacheiss)
Thu Apr 13 13:27:04 2000
Message-Id: <200004131726.NAA27390@shock-treatment.mit.edu>
To: Qing Dong <dongq@MIT.EDU>
cc: moiradev@MIT.EDU, pbh@MIT.EDU, dalmeida@MIT.EDU
In-Reply-To: Your message of "Wed, 12 Apr 2000 16:55:46 EDT."
<200004122055.QAA02087@melbourne-city-street.MIT.EDU>
Date: Thu, 13 Apr 2000 13:26:55 -0400
From: Garry Zacheiss <zacheiss@MIT.EDU>
I haven't finished reviewing this yet, but here are some general
comments.
I'd prefer using "winshell" as the name for the column and related
variables. It's not as long and conveys all the necessary information,
as far as I can tell.
>> We are also thinking about making changes to the current chsh program or
>> create a similar new program to allow the users to make changes to their
>> windows shells easily.
I'd prefer modifying chsh to a new client program.
>> #define DEFAULT_CLASS "?"
>>
>> + #define DEFAULT_WINCONSOLESHELL "cmd"
>>
>> +
>> /* Function Name: UserState
You appear to have added an additional blank link here.
>> ! /* User Information queries v3*/
Incredible nitpick, but I've been using commas before the version
number in comments of this form, and would like to keep the format
consistant.
>> Index: qfollow.pc
For all the changes to qfollow.pc, I'd suggest replacing argv[3],
etc, with argv[U_LAST], etc, to save future annoyance.
>> Index: queries2.c
Thanks for keeping the old queries around and bumping the version
number for the schema change. You will need to keep the old query
fields and validation structs around for the old versions of the queries
to continue to work. What I recommend doing is making a copy of the
fields variable and adding a "2", ie.:
static char *auac2_fields[] = {
"login", "unix_uid", "shell", "last", "first", "middle", "status",
"clearid", "class", "comments", "signature", "secure",
};
static char *auac_fields[] = {
"login", "unix_uid", "shell", "winconsoleshell", "last", "first",
"middle", "status", "clearid", "class", "comments", "signature",
"secure",
};
and similarly for the validation objects. The patches I submitted
recently for distinguishing between NFS groups and non-NFS groups
contain examples of this with the glin, alis, and ulis queries, if you'd
like a better example.
>> ! /* Q_GALO - GET_ALL_LOGINS v3*/
I'll be picky about the format of the comment again. Comma before
the v3, please.
In what time frame were you envisioning these changes going into the
production database? It's close enough to drop date that they won't be
getting in by then, which means the earliest they'll be able to make it
in is close to the end of May. If they won't be needed until later than
that, that's even better.
Let me know if you have any questions about any of this.
Garry
