[1483] in Moira
Re: ghbo
daemon@ATHENA.MIT.EDU (Dan Winship)
Fri Mar 24 13:09:07 2000
Message-Id: <200003241808.NAA1194797@antharia.mit.edu>
To: Garry Zacheiss <zacheiss@MIT.EDU>
cc: moiradev@MIT.EDU
In-Reply-To: Your message of "Thu, 23 Mar 2000 16:26:21 EST."
<200003232126.QAA01008@wing-commander.mit.edu>
Date: Fri, 24 Mar 2000 13:08:58 -0500
From: Dan Winship <danw@MIT.EDU>
> ! char name[LIST_NAME_SIZE], *type = atype;
> --- 671,677 ----
> ! char name[MACHINE_NAME_SIZE], *type = atype;
That's not correct. At some point in the future, LIST_NAME_SIZE might
be larger than MACHINE_NAME_SIZE. You need to either have separate
listname and machinename variables or use MAX_FIELD_WIDTH.
(Ah. It looks like the existing code is already wrong. There used to
be hardcoded sizes everywhere, and I didn't get everything quite
perfect when I added the symbolic names.)
I'd hope there's a less cut-and-pasty way of writing
get_host_by_owner(), but, knowing the code, I wouldn't count on it.
:-/
What are you planning on acling ghbo to? Karl's idea had been to make
it take a subnet argument as well, and you could then use it on any
subnet you have bits on. With your implementation, it wouldn't be
possible to restrict the RCCs to RCC networks, which people might care
about.
-- Dan
