[1443] in Moira
Re: moira server patch
daemon@ATHENA.MIT.EDU (Jonathon Weiss)
Tue Mar 14 02:28:38 2000
Message-Id: <200003140728.CAA00954@stratton-forty-eight.mit.edu>
From: Jonathon Weiss <jweiss@MIT.EDU>
To: Garry Zacheiss <zacheiss@MIT.EDU>
cc: moiradev@MIT.EDU
In-reply-to: Your message of "Mon, 13 Mar 2000 21:18:50 EST."
<200003140218.VAA31777@alice-whacker.mit.edu>
Date: Tue, 14 Mar 2000 02:28:35 EST
> /* Select all IMAP nfsphys entries in order of increasing
> * (allocated - partsize). Since partsize will always be larger
> * than allocated, this number will always be negative, and
> * the first row fetched (which is the only one we take)
> * will be the partition with the most unallocated space.
> */
There is a blatant lie in the above comment, you should change it
before committing the patch.
> ! /* Only update usage count if we created a pobox */
> ! if (!po_exists)
> ! set_pop_usage(mid, 1);
This if should probably also check that it is a POP box, since we
don't keep track of the number of users on the IMAP servers.
I don't particularly feel the need to see an updated version of this
patch before you check it in.
It's worth noting that if we have a 10G partition with 11G allocated
and a 20G partition with 21.5G allocated, the code will chose the 10G
partition (at least I think it will) even tho it is overallocated by a
larger percentage, since it is overallocated by a smaller number of
gigs. I don't think this is a really big deal.
Jonathon
