[1429] in Moira
Re: user changed pobox
daemon@ATHENA.MIT.EDU (Jonathon Weiss)
Mon Mar 13 18:18:25 2000
Message-Id: <200003132318.SAA11223@speaker-for-the-dead.mit.edu>
From: Jonathon Weiss <jweiss@MIT.EDU>
To: Garry Zacheiss <zacheiss@MIT.EDU>
cc: "Tom Coppeto" <tom@MIT.EDU>, "Ron Hoffmann" <hoffmann@MIT.EDU>,
bug-moira@MIT.EDU
In-reply-to: Your message of "Sun, 12 Mar 2000 18:21:25 EST."
<200003122321.SAA08182@mary-kay-commandos.mit.edu>
Date: Mon, 13 Mar 2000 18:18:16 -0500
> >> However it looks like the "safety" patch to not allow post office
> >> servers to appear in smtp strings isn't taking effect. Probably because
> >> the service type is "postoffice" and not "pop".
>
> Here's a patch to fix this.
> + case POTYPE_IMAP:
> + com_err(whoami, 0, "Cannot forward mail to IMAP server %s\n",
> + machine);
> + status = MRCL_REJECT;
> + goto cleanup;
> +
I'd like to see this error message do sometheing to be a little more
helpful, perhaps suggesting that they not use an SMTP box to get local
delivery. (Look at the POTYPE_MAILHUB case and come up with something
that isn't POP specific.
> ***************
> *** 146,151 ****
> --- 152,182 ----
> int status, match = 0;
> static struct save_queue *pop = NULL, *local = NULL;
> static struct save_queue *mailhub = NULL, *mailhub_name = NULL;
> + static struct save_queue *imap = NULL;
Just above here there is a comment describing this function. the
comment needs the word IMAP added in an appropriate location.
I also would have combined the declaration of imap with one of the
previous lines, but I don't really care, so that's not an objection.
> + while (sq_get_data(imap, &name))
> + {
> + if (!match && !strcasecmp(name, machine))
> + match = 1;
> + }
There was a comment that went with this while loop in the pop case,
since this code is being inserted before teh pop code, the comment
should be moved up.
Jonathon
