[1403] in Moira
Re: zephyr.gen shouldn't coredump
daemon@ATHENA.MIT.EDU (Garry Zacheiss)
Wed Mar 8 00:13:16 2000
Message-Id: <200003080513.AAA15167@sweet-transvestite.mit.edu>
To: Dan Winship <danw@MIT.EDU>
Cc: moiradev@MIT.EDU
In-Reply-To: Your message of "Tue, 07 Mar 2000 20:46:10 EST."
<200003080146.UAA468588@steve-dallas.mit.edu>
Date: Wed, 08 Mar 2000 00:13:12 -0500
From: Garry Zacheiss <zacheiss@MIT.EDU>
>> ick. why not just make dump_krb_acl exit(1)?
Well, I'd tather not exit(1) because "Cannot connect to Moira server"
isn't a very useful error message for the situation. Exiting with some
other value seems ok, although I was originally hesitant to do so.
Here's the reductionist version of the previous patch, submitted for
your approval.
Index: genacl.pc
===================================================================
RCS file: /afs/athena.mit.edu/astaff/project/moiradev/repository//moira/gen/genacl.pc,v
retrieving revision 1.2
diff -c -r1.2 genacl.pc
*** genacl.pc 2000/03/06 21:32:28 1.2
--- genacl.pc 2000/03/08 05:10:41
***************
*** 47,53 ****
sq = get_acl(type, id, NULL);
while (sq_remove_data(sq, &m))
{
! if (m->type != 'S' && m->name != NULL)
{
canon_krb(m, vers, kbuf, sizeof(kbuf));
fprintf(out, "%s\n", kbuf);
--- 47,55 ----
sq = get_acl(type, id, NULL);
while (sq_remove_data(sq, &m))
{
! if (m->name == NULL)
! exit(MR_DBMS_ERR);
! if (m->type != 'S')
{
canon_krb(m, vers, kbuf, sizeof(kbuf));
fprintf(out, "%s\n", kbuf);
