[1387] in Moira
Moira Pismere patches review/update
daemon@ATHENA.MIT.EDU (Danilo Almeida)
Thu Mar 2 06:31:06 2000
From: "Danilo Almeida" <dalmeida@MIT.EDU>
To: <dtanner@MIT.EDU>, <rbasch@MIT.EDU>
Cc: <moiradev@MIT.EDU>
Date: Thu, 2 Mar 2000 06:30:51 -0500
Message-Id: <DIEILAKKMPNAOBPOMHLBGELLCAAA.dalmeida@mit.edu>
Mime-Version: 1.0
Content-Type: text/plain;
charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
I have an updated set of moira diffs for building it under Pismere. I went
though the code and put in some more abstractions. I also noticed that Dave
cleaned up a lot of potential compiler warnings. That encouraged me to try
to clean up some more.
The only concern I have at this point is the curses stuff in the moira
client and the mailmaint client. I'd like to talk to Dave about it. I did
clean that up some, but I'd like us all to understand that code.
As I see it, I think the patches are ready to go in. Therefore, I'd like to
sit down with Dave and Bob and review them.
How about the three of us get together tomorrow...err...today (Thursday)
after the pismere team meeting? Bob, that should be done at around 3pm. If
we're all in earlier, though, I'd prefer to meet earlier.
Dave, I'm putting clean copies of your source and my source along with a cvs
diff in my fqd public dir under moira. (You'll see why I have a copy of
your clean sources there if you try to windiff mine against the stuff on
your machine. That darned AFS client...)
Bob, you can get the cvs diff at /mit/dalmeida/Public/moira/moira.dan.diff
(you should use -l with patch because I used -cw). In addition to the
diffs, there will be several new files related to building with the Pismere
build system:
Makefile.dir
clients/Makefile.dir
clients/addusr/Makefile.src
clients/blanche/Makefile.src
clients/lib/Makefile.src
clients/mailmaint/Makefile.src
clients/moira/Makefile.src
clients/mrcheck/Makefile.src
clients/mrtest/Makefile.src
clients/stella/Makefile.src
lib/Makefile.src
util/Makefile.dir
util/et/Makefile.src
We will also need to break out each program in clients/passwd into a
separate directory like we discussed (resulting in additional Makefile.src
files). In addition, to compile the .et files, we will need an extra
directory with the following files: Makefile.src, et_c.awk, et_h.awk.
[Note: The Makefile.dir files can be collapsed into a single Makefile.dir if
we really feel there's a need.]
I'd like to get the code checked in ASAP. At this point, I think we have
most of the big stuff taken care of. We can worry about adding abstractions
to clean things up further once the big stuff is in.
I tried out the code on Athena, and it seems to run fine. I dunno whether
there's a test suite I'm supposed to run...
Alright, I'm gonna go home and take a shower.
- Danilo
