[1320] in Moira
RE: Allow / in email address
daemon@ATHENA.MIT.EDU (Tom Coppeto)
Fri Feb 4 04:15:35 2000
From: "Tom Coppeto" <tom@MIT.EDU>
To: "Robert A Basch" <rbasch@mit.edu>, <moiradev@mit.edu>
Cc: <postmaster@mit.edu>, <system-mail@mit.edu>
Date: Fri, 4 Feb 2000 04:26:58 -0500
Message-ID: <LOBBKCACJFFHINLMJMGECEBICBAA.tom@mit.edu>
MIME-Version: 1.0
Content-Type: text/plain;
charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
In-Reply-To: <200002032336.SAA11681@aupair.mit.edu>
It's not a moira bug. It may or may not be a mail bug. I'd rather there not
be moira changes that affect mailhub configs when the right hand doesn't
know what the left is doing. Please excuse my sensitivity, there's a lot of
email shit going on right now.
Having said that, users should not be able to enter pipes or pathnames
anywhere in the address (I didn't see anything about redirects in the patch
btw). However, I can see leaving a hook for a small acl to override the
protections and help the folks who are maintaining these exception cases
manually in local configs.
In other words, the choices are to continue to punt or set up a process for
manual vetting of questionable addressing. I haven't felt a lot of demand
for this.
- Tom
-----Original Message-----
From: Robert A Basch [mailto:rbasch@MIT.EDU]
Sent: Thursday, February 03, 2000 6:37 PM
To: moiradev@MIT.EDU
Subject: Allow / in email address
[I showed this to Dan the other day, but haven't checked it in yet, so...]
This fixes the first item in the current ~moiradev/bugs list. It allows
a '/' in an email address, except as the first character, for Lotus Notes
addresses, etc.
This server change seems to be all that is needed; I tested the chpobox,
blanche, and moira clients, as well as mailhub.gen (I assume there's no
problem with '/' in an address in aliases).
Index: qsupport.pc
===================================================================
RCS file:
/afs/athena.mit.edu/astaff/project/moiradev/repository/moira/server/qsupport
.pc,v
retrieving revision 2.19
diff -c -r2.19 qsupport.pc
*** qsupport.pc 2000/01/28 00:31:58 2.19
--- qsupport.pc 2000/01/28 23:28:08
***************
*** 76,82 ****
}
else if (!strcmp(argv[1], "SMTP") || !strcmp(argv[1], "SPLIT"))
{
! if (strchr(box, '/') || strchr(box, '|'))
return MR_BAD_CHAR;
status = name_to_id(box, STRINGS_TABLE, &id);
if (status == MR_NO_MATCH)
--- 76,83 ----
}
else if (!strcmp(argv[1], "SMTP") || !strcmp(argv[1], "SPLIT"))
{
! /* Allow '/' in middle (but not start) of address. */
! if (*box == '/' || strchr(box, '|'))
return MR_BAD_CHAR;
status = name_to_id(box, STRINGS_TABLE, &id);
if (status == MR_NO_MATCH)
***************
*** 202,208 ****
status = id_to_name(mid, STRINGS_TABLE, &buf);
if (status)
return status;
! if (strchr(buf, '/') || strchr(buf, '|'))
{
free(buf);
return MR_BAD_CHAR;
--- 203,210 ----
status = id_to_name(mid, STRINGS_TABLE, &buf);
if (status)
return status;
! /* Allow '/' in middle (but not start) of address. */
! if (*buf == '/' || strchr(buf, '|'))
{
free(buf);
return MR_BAD_CHAR;
