[9085] in Athena Bugs

home help back first fref pref prev next nref lref last post

rt 7.3P: Emacs discuss w/selective-display + fix

daemon@ATHENA.MIT.EDU (Calvin Clark)
Thu Mar 12 23:47:06 1992

Date: Thu, 12 Mar 92 23:46:19 -0500
From: Calvin Clark <ckclark@mit.edu>
To: bugs@Athena.MIT.EDU
Cc: bug-discuss@Athena.MIT.EDU
Reply-To: ckclark@mit.edu

System name:		bill-the-cat
Type and version:	RTPC-ROMPC 7.3P
Display type:		apa16

What were you trying to do?
	
	I read discuss in Emacs with selective-display set to 2 so
	that only meetings with new transactions appear in the
	*meetings* buffer.  This can be done by putting a line like
	this in your .emacs file, for those who are curious:
	
	(setq discuss-mode-hook
		(function (lambda () (set-selective-display 2))))
	
What's wrong:
	
	When I try to delete a meeting, it leaves the line with the
	deleted meeting displayed, and when I try to go to any
	meeting after the deleted meeting by typing `g' on the
	appropriate line, it goes to the meeting *after* the one
	I've selected.  This can be confusing.  Typing CTRL-L before
	doing anything after deleting a meeting will fix this.
	
What should have happened:
	
	When a meeting is deleted, the `c' in the second column is
	replaced with a space, which means that selective-display
	should not display that line anymore.  This does not happen
	automatically, however.  The fix is to call redraw-display
	after deleting a meeting if selective-display is set.  I
	have also replaced the cryptic hardcoded ascii codes 32 and
	68 with space and `D' repectively in order to make the code
	more readable:
	
*** /mit/discuss/source/edsc/discuss-misc.el	Thu Aug  8 16:06:12 1991
--- discuss-misc.el	Thu Mar 12 23:40:24 1992
***************
*** 130,140 ****
      (beginning-of-line)
      (forward-char 1)
      (let ((buffer-read-only nil))
!       (insert-char 32 1)
        (delete-char 1)
        (forward-char 2)
!       (insert-char 68 1)
!       (delete-char 1)))
    (message "Meeting %s deleted." (car discuss-form)))
  
  
--- 130,141 ----
      (beginning-of-line)
      (forward-char 1)
      (let ((buffer-read-only nil))
!       (insert-char ?\  1)
        (delete-char 1)
        (forward-char 2)
!       (insert-char ?D 1)
!       (delete-char 1)
!       (if selective-display (redraw-display))))
    (message "Meeting %s deleted." (car discuss-form)))

Please describe any relevant documentation references:

	N/A

home help back first fref pref prev next nref lref last post