[8668] in Athena Bugs

home help back first fref pref prev next nref lref last post

from

daemon@ATHENA.MIT.EDU (tom@MIT.EDU)
Mon Nov 25 14:33:21 1991

From: tom@MIT.EDU
Date: Mon, 25 Nov 91 14:33:03 EST
To: bugs@MIT.EDU
Cc: postmaster@MIT.EDU


The source of the mbuf leak problem on the post offices has been
tracked down to the "from" command. When the "-t" option is given or
there is no mail waiting for the user, "from" exitted improperly. This
in turn tickles a memory managemnt bug on the server. The sipb pfrom
does not have this problem.

postmasters: keep in mind that everytime someone logs in, their mail
will wind up in .user.temp due to the incompletion of the session.
Though this doesn't break anything, it may be confusing.


Please audit/apply the following patch.	


*** from.c      Thu Nov 21 21:30:02 1991
--- /source/athena/athena.bin/from/from.c       Fri Aug 16 15:02:32 1991
***************
*** 260,265 ****
--- 260,266 ----
  		return -1;
  	}
  	if (nmsgs == 0) {
+ 	        (void) pop_command("QUIT");
  		return(0);
  	}
  	if (verbose || totals)
***************
*** 266,273 ****
  		printf("You have %d %s (%d bytes) on %s%c\n",
  		       nmsgs, nmsgs > 1 ? "messages" : "message",
  		       nbytes, host, verbose ? ':' : '.');
! 	if (totals)
  		return nmsgs;
  	if (printhdr)
  		puts("POP mail:");
  
--- 267,276 ----
  		printf("You have %d %s (%d bytes) on %s%c\n",
  		       nmsgs, nmsgs > 1 ? "messages" : "message",
  		       nbytes, host, verbose ? ':' : '.');
! 	if (totals) {
! 	        (void) pop_command("QUIT");
  		return nmsgs;
+ 	}
  	if (printhdr)
  		puts("POP mail:");
  

home help back first fref pref prev next nref lref last post