[7324] in Athena Bugs

home help back first fref pref prev next nref lref last post

rt 7.2R: /bin/login

daemon@ATHENA.MIT.EDU (daemon@ATHENA.MIT.EDU)
Sat Mar 16 22:14:24 1991

Date: Sat, 16 Mar 91 22:14:10 -0500
From: "Jonathan I. Kamens" <jik@pit-manager.MIT.EDU>
To: bugs@ATHENA.MIT.EDU

System name:		pit-manager
Type and version:	RTPC-ROMPC 7.2R
Display type:		apa16
			megapel

What were you trying to do?
	Compile /bin/login with some modifications.

What's wrong:
	Missing parentheses in #define's for TRUE and FALSE can cause
	the compiler to get confused if it sees the string "=TRUE" in
	the source code.

What should have happened:
	#define'd expressions should be parenthesized.

Please describe any relevant documentation references:
	Patch below.

  jik

*** /tmp/,RCSt1015902	Sat Mar 16 22:10:42 1991
--- login.c	Sat Mar 16 22:10:24 1991
***************
*** 76,83 ****
  #define NMAX	sizeof(utmp.ut_name)
  
  #ifndef FALSE
! #define	FALSE	0
! #define	TRUE	-1
  #endif
  
  #ifdef VFS
--- 76,83 ----
  #define NMAX	sizeof(utmp.ut_name)
  
  #ifndef FALSE
! #define	FALSE	(0)
! #define	TRUE	(-1)
  #endif
  
  #ifdef VFS


home help back first fref pref prev next nref lref last post