[7094] in Athena Bugs
kerberos.c patch for null-pointer bug
daemon@ATHENA.MIT.EDU (daemon@ATHENA.MIT.EDU)
Tue Feb 12 15:05:04 1991
Date: Tue, 12 Feb 91 15:04:29 EST
From: John T Kohl <jtkohl@MIT.EDU>
To: bugs@MIT.EDU, kerberos-bugs@MIT.EDU
Cc: jtkohl@irc.cbm.dec.com, johara@irc.cbm.dec.com
There was/is a null-pointer bug in some error conditions. I discovered
this over the summer, but thought I had reported it...
*** /source/athena/athena.lib/kerberos/server/kerberos.c Sat Nov 11 00:45:09 1989
--- kerberos.c Wed Aug 8 05:58:39 1990
***************
*** 516,521 ****
--- 511,517 ----
if (kerno) {
klog(L_ERR_UNK, "FAILED krb_rd_req from %s: %s",
inet_ntoa(client_host), krb_err_txt[kerno]);
+ req_name_ptr = req_inst_ptr = req_realm_ptr = "";
kerb_err_reply(client, pkt, kerno, "krb_rd_req failed");
return;
}
***************
*** 532,537 ****
--- 528,536 ----
klog(L_APPL_REQ, "APPL Request %s.%s@%s on %s for %s.%s",
ad->pname, ad->pinst, ad->prealm, inet_ntoa(client_host),
service, instance, 0);
+ req_name_ptr = ad->pname;
+ req_inst_ptr = ad->pinst;
+ req_realm_ptr = ad->prealm;
if (strcmp(ad->prealm, tktrlm)) {
kerb_err_reply(client, pkt, KERB_ERR_PRINCIPAL_UNKNOWN,
