[6915] in Athena Bugs
decmips 7.2P: pic
daemon@ATHENA.MIT.EDU (daemon@ATHENA.MIT.EDU)
Fri Jan 18 10:31:15 1991
Date: Fri, 18 Jan 91 10:31:00 EST
From: John T Kohl <jtkohl@ATHENA.MIT.EDU>
To: bugs@ATHENA.MIT.EDU
System name: quicksilver
Type and version: KN01 7.2P
Display type: PM-MONO
What were you trying to do?
run pic on a broken input file.
What's wrong:
It dumped core.
What should have happened:
It shouldn't have.
I loaded it into saber, and found a few other problems, plus the errant
null-pointer bug. diffs:
*** /source/third/common/ditroff/pic/print.c Wed Jan 8 15:57:36 1986
--- print.c Fri Jan 18 10:22:33 1991
***************
*** 204,209 ****
--- 204,210 ----
nhalf = p->o_nt2 - p->o_nt1 - 1;
for (i = p->o_nt1; i < p->o_nt2; i++) {
+ if (!text[i].t_val) continue;
label(text[i].t_val, text[i].t_type, nhalf);
nhalf -= 2;
}
*** /source/third/common/ditroff/pic/pltroff.c Tue Jun 3 21:01:10 1986
--- pltroff.c Fri Jan 18 10:18:50 1991
***************
*** 395,401 ****
static char *temp = ".";
move(x, y);
! label(temp, 'L');
}
space(x0, y0, x1, y1) /* set limits of page */
--- 395,401 ----
static char *temp = ".";
move(x, y);
! label(temp, 'L',0);
}
space(x0, y0, x1, y1) /* set limits of page */
*** /source/third/common/ditroff/pic/linegen.c Wed Jan 8 15:57:28 1986
--- linegen.c Fri Jan 18 10:17:08 1991
***************
*** 186,190 ****
struct obj *splinegen(type)
{
! linegen(type);
}
--- 186,190 ----
struct obj *splinegen(type)
{
! return linegen(type);
}
Please describe any relevant documentation references:
pic(1), /mit/docsourc/doc/unix.manual.ditroff/pic/, core(5)