[6851] in Athena Bugs
decmips 7.2P: /usr/bin/refer
daemon@ATHENA.MIT.EDU (daemon@ATHENA.MIT.EDU)
Wed Jan 9 15:14:28 1991
Date: Wed, 9 Jan 91 15:14:16 EST
From: John T Kohl <jtkohl@ATHENA.MIT.EDU>
To: bugs@ATHENA.MIT.EDU
System name: quicksilver
Type and version: KN01 7.2P
Display type: PM-MONO
What were you trying to do?
run /usr/bin/refer
What's wrong:
It can dump core due to null-pointer derefs.
What should have happened:
It shouldn't have dumped core. Here's a patch:
% diff -c /source/third/common/ditroff/refer/refer5.c refer5.c
*** /source/third/common/ditroff/refer/refer5.c Wed Jan 8 15:58:04 1986
--- refer5.c Wed Jan 9 15:08:06 1991
***************
*** 367,373 ****
for(i=0; i <= refnum; i++)
{
if (i==or) continue;
! if (strcmp(labtab[i], s)!=SAME)
continue;
uniq=0;
if (newr[i] != 0 && newr[i] < nr)
--- 367,373 ----
for(i=0; i <= refnum; i++)
{
if (i==or) continue;
! if (!labtab[i] || (strcmp(labtab[i], s)!=SAME))
continue;
uniq=0;
if (newr[i] != 0 && newr[i] < nr)
Please describe any relevant documentation references:
refer(1), core(5)
