[6592] in Athena Bugs

home help back first fref pref prev next nref lref last post

R4 twm destroys icon windows that aren't its own

daemon@ATHENA.MIT.EDU (daemon@ATHENA.MIT.EDU)
Wed Dec 12 17:50:21 1990

From: cfields@ATHENA.MIT.EDU
Date: Wed, 12 Dec 90 17:49:57 -0500
To: xbugs@expo.lcs.mit.edu, bugs@MIT.EDU

                          X Window System Bug Report
                            xbugs@expo.lcs.mit.edu


VERSION:
    R4

CLIENT MACHINE and OPERATING SYSTEM:
    All platforms

DISPLAY TYPE:
    Any

WINDOW MANAGER:
    twm

AREA:
    twm

SYNOPSIS:
    twm destroys icon windows that do not belong to it

DESCRIPTION:
    If an application creates a window with an icon window, then
    destroys or unmaps that window, twm destroys the associated
    icon window. twm already keeps a flag indicating whether the
    icon window belongs to it or not, and just fails to check it
    when it gets the destroy/unmap notify for the associated
    window.

SAMPLE FIX:
    IconDown may still want to be called; I haven't been able to figure
    out what it really does, however. This patch functions without it...

*** events.c		Wed Dec 12 16:49:01 1990
--- events.c.old	Wed Dec 12 16:49:18 1990
***************
*** 1143,1149 ****
      if (Tmp_win->gray) XFreePixmap (dpy, Tmp_win->gray);

      XDestroyWindow(dpy, Tmp_win->frame);
!     if (Tmp_win->icon_w && !Tmp_win->icon_not_ours) {
        XDestroyWindow(dpy, Tmp_win->icon_w);
        IconDown (Tmp_win);
      }
--- 1143,1149 ----
      if (Tmp_win->gray) XFreePixmap (dpy, Tmp_win->gray);

      XDestroyWindow(dpy, Tmp_win->frame);
!     if (Tmp_win->icon_w) {
        XDestroyWindow(dpy, Tmp_win->icon_w);
        IconDown (Tmp_win);
      }

home help back first fref pref prev next nref lref last post