[6482] in Athena Bugs

home help back first fref pref prev next nref lref last post

suggested change to zmailnotify

daemon@ATHENA.MIT.EDU (daemon@ATHENA.MIT.EDU)
Wed Nov 28 13:46:34 1990

Date: Wed, 28 Nov 90 13:46:18 -0500
From: Mark W. Eichin <eichin@ATHENA.MIT.EDU>
To: bugs@ATHENA.MIT.EDU


In the current release, long (>100K?) email messages cause zmailnotify
to spend a long time processing them (with the mailbox locked.) This
interferes with incoming mail. I'd suggest
	1) changing "multiline" to detect a blank line (as end of
headers) and flush the rest of output, returning DONE
	2) have "mbx_write" not use realloc, but create a large (10K?)
static array and just punt anything more than that (or at least not
realloc *so* inefficiently...)
	3) on general principles, call pop_command("QUIT") and
pop_close() *before* calling mail_notify, so that the mailbox doesn't
stay locked while waiting for zephyr functions (at that, perhaps
z_kind should be UNSAFE, instead of UNACKED.)

						_Mark_
ps. I'm looking at the sources in
/mit/zephyr/src/clients/zmailnotify/zmailnotify.c.

home help back first fref pref prev next nref lref last post