[5818] in Athena Bugs
pmax/ultrix bug fixes for GMS
daemon@ATHENA.MIT.EDU (John T Kohl)
Fri Aug 24 10:23:40 1990
Date: Fri, 24 Aug 90 10:23:22 -0400
From: John T Kohl <jtkohl@ATHENA.MIT.EDU>
To: bugs@ATHENA.MIT.EDU
These are relative to the PANSS tape. One bug fix; some flexibility
enhancements.
*** /tmp/,RCSt1007938 Fri Aug 24 10:21:02 1990
--- Makefile Wed Aug 1 00:08:26 1990
***************
*** 14,19 ****
--- 14,22 ----
PROJECT= gms
TARGET= get_message
SERVER= messaged
+ BINDIR=/usr/athena/bin
+ SERVERDIR=/usr/athena/etc
+ MANDIR=/usr/athena/man
CSRCS= get_a_message.c get_fallback_file.c get_message.c get_message_from_server.c get_servername.c gethost_errors.c hesiod_errors.c put_fallback_file.c read_to_memory.c view_message_by_tty.c view_message_by_zephyr.c check_viewable.c
***************
*** 30,36 ****
ALLSRCS= $(CSRCS) $(ETSRCS)
! CFLAGS= ${INCLUDE}
DEPEND=makedepend
COMPILE_ET=compile_et
--- 33,40 ----
ALLSRCS= $(CSRCS) $(ETSRCS)
! DEFINES=-DZWRITE=\"/usr/athena/bin/zwrite\"
! CFLAGS= ${INCLUDE} ${DEFINES} -g
DEPEND=makedepend
COMPILE_ET=compile_et
***************
*** 48,60 ****
$(CC) $(CFLAGS) -o $@ $(TARGET).o $(LIBS)
install: $(TARGET) $(SERVER)
! install -c -s $(TARGET) ${DESTDIR}/bin/athena/$(TARGET)
! install -c get_message.1 ${DESTDIR}/usr/man/man1
! install -c -s $(SERVER) ${DESTDIR}/etc/athena/$(SERVER)
server: $(SERVER)
! MDFLAGS=-DGMS_SERVER_MESSAGE=\"/site/Message\"
message_daemon.o: message_daemon.c
$(CC) $(CFLAGS) $(MDFLAGS) -c message_daemon.c
--- 52,64 ----
$(CC) $(CFLAGS) -o $@ $(TARGET).o $(LIBS)
install: $(TARGET) $(SERVER)
! install -c -s $(TARGET) ${DESTDIR}$(BINDIR)/$(TARGET)
! install -c get_message.1 ${DESTDIR}$(MANDIR)/man1/
! install -c -s $(SERVER) ${DESTDIR}$(SERVERDIR)/$(SERVER)
server: $(SERVER)
! MDFLAGS=-DGMS_SERVER_MESSAGE=\"/usr/athena/etc/Message\"
message_daemon.o: message_daemon.c
$(CC) $(CFLAGS) $(MDFLAGS) -c message_daemon.c
*** /tmp/,RCSt1007938 Fri Aug 24 10:21:05 1990
--- get_servername.c Wed Aug 1 00:13:36 1990
***************
*** 37,42 ****
--- 37,43 ----
/* Copy the Hesiod data into stable space. */
for(datacnt=0; data[datacnt++]; ); /* count the data */
+ datacnt--; /* don't include last null */
retval = (char **)malloc(datacnt * sizeof(char *));
for(i=0; i<datacnt; i++) {
retval[i] = malloc(strlen(data[i])+1);
*** /tmp/,RCSt1007938 Fri Aug 24 10:21:08 1990
--- globalmessage.h Mon Jul 23 23:50:24 1990
***************
*** 38,43 ****
--- 38,47 ----
/* log_10(2^32) >= 10, plus a NL, plus a NUL */
#define GMS_TIMESTAMP_LEN 12
+
+ #ifndef ZWRITE
+ #define ZWRITE "/usr/athena/zwrite"
+ #endif
#define BFSZ 1024
*** /tmp/,RCSt1007938 Fri Aug 24 10:21:11 1990
--- view_message_by_zephyr.c Mon Jul 23 23:50:50 1990
***************
*** 43,49 ****
/* check that there is *something* after the headers */
if(*ptr) {
/* don't even fork... this just exits anyway... */
! execl("/usr/athena/zwrite",
"zwrite", "-d", "-q", "-n", whoami, "-m", ptr, 0);
/* put logging here in case the exec fails. */
syslog(LOG_INFO, "GMS client execl of zwrite failed [%s]",
--- 43,49 ----
/* check that there is *something* after the headers */
if(*ptr) {
/* don't even fork... this just exits anyway... */
! execl(ZWRITE,
"zwrite", "-d", "-q", "-n", whoami, "-m", ptr, 0);
/* put logging here in case the exec fails. */
syslog(LOG_INFO, "GMS client execl of zwrite failed [%s]",
