[5798] in Athena Bugs

home help back first fref pref prev next nref lref last post

vax 7.1H: mkcred

daemon@ATHENA.MIT.EDU (lwvanels@MIT.EDU)
Wed Aug 22 23:16:32 1990

From: lwvanels@MIT.EDU
Date: Wed, 22 Aug 90 23:16:16 -0400
To: bugs@ATHENA.MIT.EDU

What were you trying to do?
	Run mkcred without specifying a filename

What's wrong:
	FIONAVAR ~)/usr/etc/mkcred
	usage: mkcred filename

What should have happened:
	It should use /usr/etc/credentials by default, as it says on the man
	page.

Please describe any relevant documentation references:
	mkcred(8)

Here's the patch:

*** /tmp/,RCSt1013687	Wed Aug 22 23:12:19 1990
--- mkcred.c	Wed Aug 22 23:09:50 1990
***************
*** 13,34 ****
  
  #define LINESIZE 4096
  
  main(argc, argv)
  char *argv[];
  {
  	FILE *f;
! 	char line[LINESIZE];
  
! 	if (argc < 2) {
! 		fprintf(stderr, "usage: mkcred filename\n");
  		exit(-1);
  	}
! 	if ((f = fopen(argv[1], "r")) == NULL) {
! 		fprintf(stderr, "Can't open %s for reading\n", argv[1]);
  		exit(-1);
  	}
! 	if (open_cred(argv[1]) < 0) {
! 		fprintf(stderr, "Can't create database files\n", argv[1]);
  		exit(-1);
  	}
  	while(fgets(line, LINESIZE, f) != NULL)
--- 13,40 ----
  
  #define LINESIZE 4096
  
+ char *default_name = "/usr/etc/credentials";
+ 
  main(argc, argv)
  char *argv[];
  {
  	FILE *f;
! 	char line[LINESIZE], *filename;
  
! 	if (argc > 2) {
! 		fprintf(stderr, "usage: mkcred [filename]\n");
  		exit(-1);
  	}
! 	if (argc == 1)
! 	  filename = default_name;
! 	else
! 	  filename = argv[1];
! 	if ((f = fopen(filename, "r")) == NULL) {
! 		fprintf(stderr, "Can't open %s for reading\n", filename);
  		exit(-1);
  	}
! 	if (open_cred(filename) < 0) {
! 		fprintf(stderr, "Can't create database files\n");
  		exit(-1);
  	}
  	while(fgets(line, LINESIZE, f) != NULL)

home help back first fref pref prev next nref lref last post