[5670] in Athena Bugs
7.1D kerberos lint library inconsistancies
daemon@ATHENA.MIT.EDU (epeisach@ATHENA.MIT.EDU)
Sun Aug 5 12:33:49 1990
From: epeisach@ATHENA.MIT.EDU
Date: Sun, 5 Aug 90 12:33:31 -0400
To: bugs@ATHENA.MIT.EDU
Cc: bug-kerberos@ATHENA.MIT.EDU
The kerberos lint library has several inconsistancies:
lint -lkrb
returns:
des_quad_cksum value declared inconsistently llib-ldes:quad_cksum.c(114) :: llib-lkrb:mk_safe.c(161)
log value declared inconsistently llib-lkrb:log.c(52) :: llib-lkrb:rd_req.c(322)
des_quad_cksum value declared inconsistently llib-ldes:quad_cksum.c(114) :: llib-lkrb:rd_safe.c(175)
krb_mk_priv value declared inconsistently llib-lkrb:mk_priv.c(116) :: llib-lkrb:recvauth.c(264)
inet_ntoa value declared inconsistently llib-lc(278) :: llib-lkrb:send_to_kdc.c(295)
krb_rd_priv value declared inconsistently llib-lkrb:rd_priv.c(91) :: llib-lkrb:sendauth.c(221)
req_act_vno used( llib-lkrb:cr_err_reply.c(74) ), but not defined
The following fixes all but the last. There is a note that cr_err_reply
is only used by servers. If that's the case then why is it in libkrb?
RCS file: RCS/mk_safe.c,v
retrieving revision 1.1
diff -c -r1.1 mk_safe.c
*** /tmp/,RCSt1007255 Sun Aug 5 12:32:20 1990
--- mk_safe.c Sun Aug 5 12:24:23 1990
***************
*** 42,47 ****
--- 42,50 ----
extern char *errmsg();
extern int errno;
extern int krb_debug;
+ #ifndef NOENCRYPTION
+ extern unsigned long quad_cksum();
+ #endif
/* static storage */
===================================================================
RCS file: RCS/rd_req.c,v
retrieving revision 1.1
diff -c -r1.1 rd_req.c
*** /tmp/,RCSt1007255 Sun Aug 5 12:32:22 1990
--- rd_req.c Sun Aug 5 12:11:59 1990
***************
*** 22,27 ****
--- 22,28 ----
#include <strings.h>
extern int krb_ap_req_debug;
+ extern void log();
static struct timeval t_local = { 0, 0 };
===================================================================
RCS file: RCS/rd_safe.c,v
retrieving revision 1.1
diff -c -r1.1 rd_safe.c
*** /tmp/,RCSt1007255 Sun Aug 5 12:32:23 1990
--- rd_safe.c Sun Aug 5 12:23:27 1990
***************
*** 40,45 ****
--- 40,48 ----
extern char *errmsg();
extern int errno;
extern int krb_debug;
+ #ifndef NOENCRYPTION
+ extern unsigned long quad_cksum();
+ #endif
/* static storage */
===================================================================
RCS file: RCS/recvauth.c,v
retrieving revision 1.1
diff -c -r1.1 recvauth.c
*** /tmp/,RCSt1007255 Sun Aug 5 12:32:24 1990
--- recvauth.c Sun Aug 5 12:02:33 1990
***************
*** 16,21 ****
--- 16,23 ----
#include <mit-copyright.h>
#include <krb.h>
+ /* Until krb_mk_priv is in krb.h XXX */
+ #include <kadm.h>
#include <sys/types.h>
#include <netinet/in.h>
#include <syslog.h>
===================================================================
RCS file: RCS/send_to_kdc.c,v
retrieving revision 1.1
diff -c -r1.1 send_to_kdc.c
*** /tmp/,RCSt1007255 Sun Aug 5 12:32:26 1990
--- send_to_kdc.c Sun Aug 5 12:17:03 1990
***************
*** 27,32 ****
--- 27,33 ----
#endif /* lint */
#include <sys/socket.h>
#include <netinet/in.h>
+ #include <arpa/inet.h>
#include <netdb.h>
#include <strings.h>
===================================================================
RCS file: RCS/sendauth.c,v
retrieving revision 1.1
diff -c -r1.1 sendauth.c
*** /tmp/,RCSt1007255 Sun Aug 5 12:32:27 1990
--- sendauth.c Sun Aug 5 12:01:45 1990
***************
*** 17,22 ****
--- 17,24 ----
#include <mit-copyright.h>
#include <krb.h>
+ /* Until krb_rd_priv is in krb.h XXX */
+ #include <kadm.h>
#include <sys/types.h>
#include <netinet/in.h>
#include <syslog.h>
