[5576] in Athena Bugs
Hesiod 7.1 version will not compile on RT
daemon@ATHENA.MIT.EDU (epeisach@ATHENA.MIT.EDU)
Thu Jul 19 09:26:12 1990
From: epeisach@ATHENA.MIT.EDU
Date: Thu, 19 Jul 90 09:25:54 -0400
To: bugs@ATHENA.MIT.EDU
Cc: bug-hesiod@ATHENA.MIT.EDU
!!!!Insert standard flaming disclaimer!!!
When we were given the changes to hesiod for 7.1, it was assumed that it
would compile on both a vax on rt. Obviously this was never done 'cause
if you try compiling hesiod.c on the RT, you get:
cc -c -pg -O -DHESIOD hesiod.c
E "hesiod.c",L118/C12: Type "int" is not assignment compatible with type "char*
".
1 user error No warnings
*** Exit 8
The fix is declare getenv() as returning char *.
This has been put into our sources and the development sources are now
out of date.
Ezra
Fix as follows:
RCS file: RCS/hesiod.c,v
retrieving revision 1.8
diff -c -r1.8 hesiod.c
*** /tmp/,RCSt1008262 Thu Jul 19 09:21:57 1990
--- hesiod.c Thu Jul 19 09:20:45 1990
***************
*** 1,9 ****
/* This file is part of the Hesiod library.
*
* $Source: /afs/rel-eng.athena.mit.edu/project/release/current/source/athena/athena.lib/hesiod/RCS/hesiod.c,v $
! * $Author: probe $
* $Athena: hesiod.c,v 1.5 88/08/07 22:00:44 treese Locked $
* $Log: hesiod.c,v $
* Revision 1.8 90/07/11 16:46:44 probe
* Patches from <mar>
* Support for HES_DOMAIN environment variable added
--- 1,12 ----
/* This file is part of the Hesiod library.
*
* $Source: /afs/rel-eng.athena.mit.edu/project/release/current/source/athena/athena.lib/hesiod/RCS/hesiod.c,v $
! * $Author: epeisach $
* $Athena: hesiod.c,v 1.5 88/08/07 22:00:44 treese Locked $
* $Log: hesiod.c,v $
+ * Revision 1.9 90/07/19 09:20:09 epeisach
+ * Declare that getenv returns a char*
+ *
* Revision 1.8 90/07/11 16:46:44 probe
* Patches from <mar>
* Support for HES_DOMAIN environment variable added
***************
*** 54,60 ****
#include "mit-copyright.h"
#ifndef lint
! static char rcsid_hesiod_c[] = "$Header: /afs/rel-eng.athena.mit.edu/project/release/current/source/athena/athena.lib/hesiod/RCS/hesiod.c,v 1.8 90/07/11 16:46:44 probe Exp $";
#endif
#include <stdio.h>
--- 57,63 ----
#include "mit-copyright.h"
#ifndef lint
! static char rcsid_hesiod_c[] = "$Header: /afs/rel-eng.athena.mit.edu/project/release/current/source/athena/athena.lib/hesiod/RCS/hesiod.c,v 1.9 90/07/19 09:20:09 epeisach Exp $";
#endif
#include <stdio.h>
***************
*** 82,88 ****
register char *key, *cp, **cpp;
int len;
char buf[MAXDNAME+7];
! char *calloc();
Hes_Errno = HES_ER_UNINIT;
Hes_LHS = NULL; Hes_RHS = NULL;
--- 85,91 ----
register char *key, *cp, **cpp;
int len;
char buf[MAXDNAME+7];
! char *calloc(), *getenv();
Hes_Errno = HES_ER_UNINIT;
Hes_LHS = NULL; Hes_RHS = NULL;
