[5518] in Athena Bugs

home help back first fref pref prev next nref lref last post

ss ss_add_info_dir() deref's null pointer

daemon@ATHENA.MIT.EDU (Jonathan I. Kamens)
Thu Jul 12 03:13:56 1990

Date: Thu, 12 Jul 90 03:13:32 -0400
From: "Jonathan I. Kamens" <jik@pit-manager.MIT.EDU>
To: bugs@ATHENA.MIT.EDU


I think the following patch speaks for itself.  Note that there are
probably a number of versions of the ss library in our source tree,
and this should affect all of them.

*** /source/athena/athena.lib/ss/help.c	Wed Jan 25 07:25:50 1989
--- help.c	Thu Jul 12 03:12:52 1990
***************
*** 94,100 ****
      register char **dirs;
  
      info = ss_info(sci_idx);
!     if (info_dir == NULL && *info_dir) {
  	*code_ptr = SS_ET_NO_INFO_DIR;
  	return;
      }
--- 94,100 ----
      register char **dirs;
  
      info = ss_info(sci_idx);
!     if (info_dir == NULL || *info_dir == '\0') {
  	*code_ptr = SS_ET_NO_INFO_DIR;
  	return;
      }

home help back first fref pref prev next nref lref last post