[4819] in Athena Bugs

home help back first fref pref prev next nref lref last post

rt 6.4R: moira

daemon@ATHENA.MIT.EDU (Jonathan I. Kamens)
Wed Apr 25 10:13:29 1990

Date: Wed, 25 Apr 90 10:13:14 -0400
From: "Jonathan I. Kamens" <jik@pit-manager.MIT.EDU>
To: bugs@ATHENA.MIT.EDU
System name:		pit-manager
Type and version:	RTPC-ROMPC 6.4R
Display type:		apa16
			megapel

What were you trying to do?
	Compile the new version of moira just installed in the source
	tree for release 7.0.

What's wrong:
	It's got a bug that any respectable compiler and/or lint
	checker should have caught.  It's a bit upsetting that bugs
	like this are in fresh code handed directly to us from the
	projects.

	Note the following compiler error when compiling code from
	/source/athena/athena.lib/moira/clients/moira:

	cc -I/source/athena/athena.lib/moira/include -I. -O -c dcmmaint.c
	w "dcmmaint.c",L269/C11:        5: Array subscript out of range.

	In particular, the following declaration is inconsistent with
	the array usage below it:

	    char *qargv[5], buf[BUFSIZ];
	...
	    qargv[5] = "";

What should have happened:
	Code handed to release engineering by project leaders should
	be able to get by hc without error messages like this.  This
	isn't even a lint error, it's a real bug.

Please describe any relevant documentation references:
	/source/athena/athena.lib/moira/clients/moira/dcmmain.c

home help back first fref pref prev next nref lref last post