[4457] in Athena Bugs

home help back first fref pref prev next nref lref last post

bug in swapgeneric.c

daemon@ATHENA.MIT.EDU (Jonathan I. Kamens)
Thu Mar 8 03:20:56 1990

Date: Thu, 8 Mar 90 03:20:40 -0500
From: Jonathan I. Kamens <jik@PIT-MANAGER.MIT.EDU>
To: bugs@ATHENA.MIT.EDU
Article 22029 in comp.unix.wizards:

In article <8340@sdcc6.ucsd.edu>, muller@sdcc10.ucsd.edu (Keith Muller) writes:
> In article <1990Mar6.140639.7408@uncecs.edu>, khj@uncecs.edu (Kenneth
H. Jacker) writes:
> > Autoconfig spotted most of our devices including the uda50, ra0 and our
> > DELUA.  The kernel then asked for the "root device", and here's where a
> > problem arose.  I tried "ra0*", "ra00*", and even "ra0", but each gave
> > the same error message:
> > 
> > 	use hp%d, up%d, ra%d, rb%d, rl%d, hk%d or kra%d.
> 
> A small bug in vax/swapgeneric.c
> 
> 	Keith Muller
> 	University of California, San Diego
> 	muller@ucsd.edu
> 
> *** bad/vax/swapgeneric.c	Tue Jun  7 10:07:53 1988
> --- good/vax/swapgeneric.c	Tue Feb  7 20:35:44 1989
> ***************
> *** 81,94 ****
>   		printf("root device? ");
>   		gets(name);
>   		for (gc = genericconf; gc->gc_driver; gc++)
> ! 		    for (cp = name, gp = gc->gc_name; *cp == *gp; cp++, gp++)
> ! 			if (*gp == 0)
>   				goto gotit;
>   		printf(
>   		  "use hp%%d, up%%d, ra%%d, rb%%d, rl%%d, hk%%d or kra%%d\n");
>   		goto retry;
>   gotit:
> ! 		if (*cp < '0' || *cp > '9') {
>   			printf("bad/missing unit number\n");
>   			goto retry;
>   		}
> --- 81,94 ----
>   		printf("root device? ");
>   		gets(name);
>   		for (gc = genericconf; gc->gc_driver; gc++)
> ! 		    for (cp = name, gp = gc->gc_name; *cp == *gp; cp++)
> ! 			if (*++gp == 0)
>   				goto gotit;
>   		printf(
>   		  "use hp%%d, up%%d, ra%%d, rb%%d, rl%%d, hk%%d or kra%%d\n");
>   		goto retry;
>   gotit:
> ! 		if (*++cp < '0' || *cp > '9') {
>   			printf("bad/missing unit number\n");
>   			goto retry;
>   		}
> ***************
> *** 96,101 ****
> --- 96,102 ----
>   			unit = 10 * unit + *cp++ - '0';
>   		if (*cp == '*')
>   			swaponroot++;
> + 		goto found;
>   	}
>   	for (gc = genericconf; gc->gc_driver; gc++) {
>   #if NMBA > 0

Jonathan Kamens			              USnail:
MIT Project Athena				11 Ashford Terrace
jik@Athena.MIT.EDU				Allston, MA  02134
Office: 617-253-8495			      Home: 617-782-0710

home help back first fref pref prev next nref lref last post