[2937] in Athena Bugs

home help back first fref pref prev next nref lref last post

Version 6.3B: /usr/athena/lib/init/login

daemon@ATHENA.MIT.EDU (Jonathan I. Kamens)
Sun Aug 20 18:52:51 1989

Date: Sun, 20 Aug 89 18:52:28 -0400
From: Jonathan I. Kamens <jik@ATHENA.MIT.EDU>
To: bugs@ATHENA.MIT.EDU, testers@ATHENA.MIT.EDU
System type, version:	Version 6.3B, all platforms

What's wrong:

  The file /usr/athena/lib/init/login contains the following near the
beginning of the file:

# Do not echo status messages if noninteractive shell.  For interactive shells,
# echo messages unless user has ~/.hushlogin file AND the session was not 
# started using the xlogin "SYSTEM" option.

if ($?prompt) then
	if ((! -r ~/.hushlogin) || ($?NOCALLS)) set verbose_login
endif

  /usr/athena/lib/init/login should never be used in an xlogin login,
so the comment about xlogin and the check for NOCALLS are unnecessary.

  Furthermore, I am not convinced the check to see if the shell is
interactive is necessary (although I am not as sure about this).
/usr/athena/lib/init/login should end up getting executed only in an
interactive login shell.

What should have happened:

  The file fragment should read:

# Do not echo status messages if noninteractive shell.  For
# interactive shells, echo messages unless user has ~/.hushlogin file.

if ($?prompt) then
  if (! -r ~/.hushlogin) set verbose_login
endif

  If the check for interactivity is determined not to be necessary,
the fragment should read:

# Echo messages unless user has ~/.hushlogin file.

if (! -r ~/.hushlogin) set verbose_login

  jik

home help back first fref pref prev next nref lref last post