[27199] in Athena Bugs
Athena firefox wrapper breaks on profile names with faces
daemon@ATHENA.MIT.EDU (Geoffrey G Thomas)
Tue Apr 29 02:14:21 2008
Date: Tue, 29 Apr 2008 02:14:07 -0400 (EDT)
From: Geoffrey G Thomas <geofft@mit.edu>
To: bugs@mit.edu
Message-ID: <alpine.DEB.1.10.0804290205400.3137@vinegar-pot.mit.edu>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; format=flowed; charset=US-ASCII
X-Spam-Flag: NO
X-Spam-Score: 0.00
Errors-To: bugs-bounces@mit.edu
Hi,
A user dropped by SIPB earlier today with a Firefox profile that wouldn't
start up but complained about a seemingly perpetual lock. Running it from
the command line indicated that it wasn't quoting the profile directory
properly when looking at the lock (and for some reason, she had created 4
profiles with name "Default User"... I didn't feel like tracing this). I
believe the following one-line patch to add quotation marks around a
reference to $locklink should fix this issue.
Thanks,
--
Geoffrey Thomas
geofft@mit.edu
--- /usr/athena/bin/firefox 2007-06-06 14:16:58.000000000 -0400
+++ - 2008-04-29 02:04:19.314064000 -0400
@@ -135,7 +135,7 @@
# Extract the IP address and PID from the contents of the symlink.
# Also note whether firefox used fnctl() to lock .parentlock,
# which is indicated with a leading '+' in the PID.
- eval `ls -l $locklink | $awk '{
+ eval `ls -l "$locklink" | $awk '{
if (split($NF, a, ":") == 2)
printf("lock_ip=%s ; lock_pid=%d ; use_fcntl=%d\n",
a[1], int(a[2]), (substr(a[2], 1, 1) == "+")); }'`
