[26265] in Athena Bugs

home help back first fref pref prev next nref lref last post

Re: linux [9.3.16]: athlsync

daemon@ATHENA.MIT.EDU (Greg Hudson)
Tue Dec 28 12:35:10 2004

From: Greg Hudson <ghudson@mit.edu>
To: Jonathon Weiss <jweiss@mit.edu>
In-Reply-To: <200412272251.iBRMpYB4002305@distraction.mit.edu>
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Message-Id: <1104255272.15714.108.camel@egyptian-gods.mit.edu>
Mime-Version: 1.0
Date: Tue, 28 Dec 2004 12:34:33 -0500
cc: bugs@mit.edu
Errors-To: bugs-bounces@mit.edu

On Mon, 2004-12-27 at 17:51, Jonathon Weiss wrote:
> 	athlsync carefully corrects for cases where someone accidently
> 	leaves offf the r or x permissions for group or other users,
> 	because they don't matter in AFS.  However, it does not strip
> 	the write bit if it is accidently left on for group/other users.

Hm.  It certainly tries to:

        static mode_t adjust_mode(mode_t mode)
        {
          mode_t rmask = S_IRGRP | S_IROTH;
          mode_t xmask = (mode & S_IXUSR) ? (S_IXGRP | S_IXOTH) : 0;
          mode_t wmask = ~(S_IWGRP | S_IWOTH);
        
          return (mode | rmask | xmask) & wmask;
        }

What locker did you notice the problem with, so that I don't have to
create a locker for testing purposes?


home help back first fref pref prev next nref lref last post