[22529] in Athena Bugs
syncconf bug: doesn't cope with empty strings
daemon@ATHENA.MIT.EDU (Derek Atkins)
Tue Jun 17 19:27:05 2003
To: bugs@MIT.EDU, testers@MIT.EDU
From: Derek Atkins <warlord@MIT.EDU>
Date: 17 Jun 2003 19:27:02 -0400
Message-ID: <sjmptlcs2t5.fsf@kikki.mit.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
If HOST or ADDR is empty, synnconf never recovers. The problem is that
it generates a broken /var/athena/rc.conf.sync:
if [ $HOST = ] ...
if [ $ADDR = ] ...
It should be changed to put quotes around the various strings
and variables:
cat > $rcsyncout << EOF
# This file was generated by /etc/athena/syncconf; do not edit.
if [ "\$HOST" != "$HOST" ]; then changes="\$changes HOSTADDR MAILRELAY"; fi
if [ "\$ADDR" != "$ADDR" ]; then changes="\$changes HOSTADDR MAILRELAY"; fi
...
-derek
--
Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
Member, MIT Student Information Processing Board (SIPB)
URL: http://web.mit.edu/warlord/ PP-ASEL-IA N1NWH
warlord@MIT.EDU PGP key available
