[2193] in Athena Bugs
zwgc and zephyr.h
daemon@ATHENA.MIT.EDU (bjaspan@ATHENA.MIT.EDU)
Sun May 7 15:36:15 1989
From: <bjaspan@ATHENA.MIT.EDU>
Date: Sun, 7 May 89 15:32:18 EDT
To: zephyr-cmts@ATHENA.MIT.EDU
Cc: bugs@ATHENA.MIT.EDU
I was looking through zwgc's source to figure out how to add 'zctl
punt', and noticed that a lot of the zwgc specific #define's used in
zwgc are NOT DEFINED ANYWHERE IN THE SOURCE. So, I took a peek in
zephyr.h and sure enough, there they were.
This is GROSS GROSS GROSS! zwgc is not the only Zephyr client, nor
is it the definitive zephyr client, and it certainly should be able
to change more frequently than the header file. Adding another
wg_<foo> option to zctl/zwgc now means that #define's for the same
sort of purpose have to appear in two totally different places,
which will be a serious b!%ch to modify in the future.
In the "next release of Zephyr" (September?) when the large number of
changes to zephyr discussed at the recent design review are
implemented, I strongly suggest the header file be completely
rewritten as well to get rid of this really disgusting design. This
should not be a problem for other Zephyr clients since if they were
written well they don't use anything that needs to be changed.
Barr3y
