[2103] in Athena Bugs
msgchk: 2 problems
daemon@ATHENA.MIT.EDU (mar@ATHENA.MIT.EDU)
Fri Apr 21 14:18:31 1989
From: <mar@ATHENA.MIT.EDU>
Date: Fri, 21 Apr 89 14:18:12 EDT
To: bugs@ATHENA.MIT.EDU
This is to correct an error message I've heard users complain about,
and a condition where xbiff makes many bad hesiod queries after the
user has logged out. These problems have existed for some time on
both platforms.
The first one is fairly straightforward, just a changed print
statement. The second one isn't a clean fix, since I'm checking the
return value of getusr() agains "intruder" rather than fixing getusr()
to return a real error indication. I took this approach because
msgchk is part of a larger package and changing the conventions of a
routine that is used throughout that package is difficult. However,
msgchk is the only program in MH that I'm aware of people using in
scripts as opposed to interactively, so it should be the only place
that this is a potential problem.
-Mark
These changes apply to /source/4.3/new/mh/uip/msgchk.c:
*** msgchk.c Fri Apr 21 14:07:21 1989
--- msgchk.c.orig Fri Apr 21 14:02:07 1989
***************
*** 141,147 ****
else
#endif POP
if ((pw = getpwuid (getuid ())) == NULL)
! adios (NULLCP, "unable to get information about user");
else
checkmail (pw, 1);
}
--- 141,147 ----
else
#endif POP
if ((pw = getpwuid (getuid ())) == NULL)
! adios (NULLCP, "you lose");
else
checkmail (pw, 1);
}
***************
*** 226,233 ****
if (user == NULL)
user = getusr ();
pass = getusr ();
- if (!strcmp(pass, "intruder")
- adios(NULLCP, "unable to identify user");
}
else
ruserpass (host, &user, &pass);
--- 226,231 ----