[17095] in Athena Bugs

home help back first fref pref prev next nref lref last post

bug in mkserv remote requiring encryption

daemon@ATHENA.MIT.EDU (Jonathon Weiss)
Thu Aug 26 00:25:23 1999

Date: Thu, 26 Aug 1999 00:25:09 -0400
Message-Id: <199908260425.AAA00828@stratton-three-o-six.mit.edu>
To: mkserv@MIT.EDU
Cc: bugs@MIT.EDU
From: Jonathon Weiss <jweiss@MIT.EDU>


In 8.3 we changed the invocation of ftpd in inetd.conf.  As a result
mkserv remote wasn't adding the -E flag when the user asked for
encryption.  (The sed exression was too tight, because it needed to be
itempotent.)  I've applied the following patch to remote.add and a
similar one to remote.del. (Uncommenting the ftpd line was needed
during 8.2 becasue of the wway we handled things during the early part
of the 8.2 release, and id not needed in 8.3).  The change will be
available after tonight's volume release.

	Jonathon



*** remote.add	1998/07/22 01:27:53	1.14
--- remote.add	1999/08/26 04:08:20
***************
*** 1,7 ****
  #!/bin/sh
  #
! # $Header: /afs/athena.mit.edu/astaff/project/mkservdev/services/RCS/remote.add,v 1.14 1998/07/22 01:27:53 jweiss Exp $
! # $Revision: 1.14 $
  # $Platforms: sun4,sgi $
  #
  
--- 1,7 ----
  #!/bin/sh
  #
! # $Header: /mit/mkservdev/services/RCS/remote.add,v 1.15 1999/08/26 04:08:20 jweiss Exp $
! # $Revision: 1.15 $
  # $Platforms: sun4,sgi $
  #
  
***************
*** 85,92 ****
  if [ "${remote_rcrypt}" = "true" ]; then
  	sed -n  -e '/^telnet.*telnetd -a cred$/s/$/ -e/' \
  		-e '/^kshell.*kshd -k$/s/$/ -e/' \
! 		-e '/^#ftp/s/^#//' \
! 		-e '/^ftp.*ftpd -a off$/s/$/ -E/' \
  		-e '/^klogin/s/^/#/' \
  		-e '/^login/s/^/#/' \
  		-e '/^shell/s/^/#/' \
--- 85,91 ----
  if [ "${remote_rcrypt}" = "true" ]; then
  	sed -n  -e '/^telnet.*telnetd -a cred$/s/$/ -e/' \
  		-e '/^kshell.*kshd -k$/s/$/ -e/' \
! 		-e '/^ftp.*ftpd -C$/s/$/ -E/' \
  		-e '/^klogin/s/^/#/' \
  		-e '/^login/s/^/#/' \
  		-e '/^shell/s/^/#/' \
***************
*** 94,101 ****
  else
  	sed -n  -e '/^telnet.* -e$/s/ -e$//' \
  		-e '/^kshell.* -e$/s/ -e$//' \
! 		-e '/^#ftp/s/^#//' \
! 		-e '/^ftp.*ftpd -a off -E$/s/ -E$//' \
  		-e '/^#klogin/s/^#//' \
  		-e '/^#login/s/^#//' \
  		-e '/^#shell/s/^#//' \
--- 93,99 ----
  else
  	sed -n  -e '/^telnet.* -e$/s/ -e$//' \
  		-e '/^kshell.* -e$/s/ -e$//' \
! 		-e '/^ftp.*ftpd -C -E$/s/ -E$//' \
  		-e '/^#klogin/s/^#//' \
  		-e '/^#login/s/^#//' \
  		-e '/^#shell/s/^#//' \


home help back first fref pref prev next nref lref last post