[16745] in Athena Bugs
Re: krb5-clients/698: ksu segfaults
daemon@ATHENA.MIT.EDU (Tom Yu)
Mon Mar 8 23:01:33 1999
Date: Mon, 8 Mar 1999 23:01:26 -0500 (EST)
To: jdaniel@MIT.EDU
Cc: bugs@MIT.EDU, krb5-bugs@MIT.EDU, sipb-athena-bugs@MIT.EDU
In-Reply-To: Jeremy Daniel's message of Mon, 1 Mar 1999 00:33:16 -0500
<199903010533.AAA28035@snorklewacker.mit.edu>
From: Tom Yu <tlyu@MIT.EDU>
The following should fix the bug. I've queued the patch for the 1.0.6
release.
---Tom
Index: heuristic.c
===================================================================
RCS file: /cvs/krbdev/krb5/src/clients/ksu/heuristic.c,v
retrieving revision 1.9
retrieving revision 1.9.8.1
diff -u -r1.9 -r1.9.8.1
--- heuristic.c 1996/05/19 18:52:48 1.9
+++ heuristic.c 1999/03/04 23:49:37 1.9.8.1
@@ -253,17 +253,19 @@
}
}
- if(retval = list_union(k5login_list, k5users_filt_list, &combined_list)){
- close_time(k5users_flag,users_fp, k5login_flag,login_fp);
- return retval;
- }
-
close_time(k5users_flag,users_fp, k5login_flag, login_fp);
if (cmd) {
+ if (retval = list_union(k5login_list,
+ k5users_filt_list, &combined_list)){
+ close_time(k5users_flag,users_fp, k5login_flag,login_fp);
+ return retval;
+ }
*princ_list = combined_list;
return 0;
} else {
+ if (k5users_filt_list != NULL)
+ free(k5users_filt_list);
*princ_list = k5login_list;
return 0;
}
