[14756] in Athena Bugs
sun4 8.0I: swtools
daemon@ATHENA.MIT.EDU (Yonah Schmeidler)
Sun Oct 13 12:17:32 1996
To: bugs@MIT.EDU, dot@MIT.EDU
Date: Sun, 13 Oct 1996 12:17:20 EDT
From: Yonah Schmeidler <yonah@MIT.EDU>
System name: portnoy
Type and version: SPARC/5 8.0I (1 update(s) to same version)
Display type: cgthree
What were you trying to do?
Run Netscape
What happened:
send_message gave a segmentation fault
What should have happened:
send_message should have worked
What's wrong:
send_message dies if .sw_messages contains a null character,
does not have a newline after the last line, or contains a line with
more than 1024 characters (including newline). Specifically, it dies
in cookie.c, line 107, because the return value from strrchr is not
checked before dereferencing (in any of the cases above, it will
return a null).
send_message should print error messages to standard error,
rather than standard output.
send_message should probably send the message and exit with
a non-zero status if there is an error (such as being unable to open
the .sw_messages.lck file for reading or writing).
