[99] in bug-owl
Re: owl fix for functions.c
daemon@ATHENA.MIT.EDU (Erik Nygren)
Tue Oct 15 23:37:10 2002
To: "James M. Kretchmar" <kretch@mit.edu>
cc: bug-owl@mit.edu
In-reply-to: Your message of "Tue, 15 Oct 2002 16:18:24 EDT."
<200210152018.QAA08278@mission-control.mit.edu>
Date: Tue, 15 Oct 2002 23:37:06 -0400
From: Erik Nygren <nygren@MIT.EDU>
Message-Id: <E181eza-0001d7-00@gaia.bay13.org>
Given that you're going to popless_text it, wouldn't
it be better to just make buff be fmtext and popless_fmtext it?
That way there is no artificial limit...
Erik
> > in 1.2.6, lines 1332 and 1333 should be
> >
> > sprintf(tmpbuff, "<%s,%s,%s>\n", sub.zsub_class, sub.zsub_classinst, sub.zsub_recipient);
> > strcat(buff,tmpbuff);
> >
> >
> > The old way copied everything into tmpbuff each time. tmpbuff was fixed
> > size and overflowed with many subscriptions.
>
> Actually, the reason for the weird code was so that the subscriptions
> would be printed in reverse from what the server returns. So instead
> I've increased the size of tmpbuff:
>
> tmpbuff=owl_malloc(num*500);
>
> And left the rest the same.
