[32] in bug-owl

home help back first fref pref prev next nref lref last post

owl clobbers TERMINFO env var

daemon@ATHENA.MIT.EDU (Yonah Schmeidler)
Wed Jun 26 12:03:35 2002

Message-Id: <200206261603.MAA19715@multics.mit.edu>
To: bug-owl@MIT.EDU
Date: Wed, 26 Jun 2002 12:03:31 -0400
From: Yonah Schmeidler <yonah@MIT.EDU>

Owl shouldn't be setting TERMINFO internally.  I'd guess that you're
trying to work around a bad default path in your ncurses build, given
this commit message

  set TERMINFO so we won't lose with ncurses

but I'm unconvinced that setting TERMINFO internally is the right
solution.  In particular, I set TERMINFO to /mit/gnu/share/terminfo
so that I can get a good entry for screen on Solaris.  I have a
workaround of creating a symlink to there from ~/.terminfo, but
that's really suboptimal.

-yonah

diff -u -r /mit/ktools/src/owl/src/config.h.in ./config.h.in
--- /mit/ktools/src/owl/src/config.h.in	Tue Jun 25 15:51:50 2002
+++ ./config.h.in	Wed Jun 26 11:53:46 2002
@@ -44,5 +44,3 @@
 
 /* Define if libzephyr contains ZInitLocationInfo */
 #undef HAVE_LIBZEPHYR_ZINITLOCATIONINFO
-
-#undef TERMINFO
diff -u -r /mit/ktools/src/owl/src/configure.in ./configure.in
--- /mit/ktools/src/owl/src/configure.in	Tue Jun 25 15:51:50 2002
+++ ./configure.in	Wed Jun 26 11:53:54 2002
@@ -86,11 +86,6 @@
 echo Adding perl LDFLAGS ${FOO}
 LDFLAGS=${LDFLAGS}\ ${FOO}
 
-dnl Checks for typedefs, structures, and compiler characteristics.
-AC_CHECK_FILE(/usr/share/terminfo, AC_DEFINE(TERMINFO, "/usr/share/terminfo"),
-  AC_CHECK_FILE(/usr/share/lib/terminfo, AC_DEFINE(TERMINFO, "/usr/share/lib/terminfo"),
-  AC_MSG_ERROR(No terminfo found for this system)))
-
 dnl Checks for library functions.
 dnl AC_PROG_GCC_TRADITIONAL
 dnl AC_CHECK_FUNCS(gethostname strdup)
diff -u -r /mit/ktools/src/owl/src/owl.c ./owl.c
--- /mit/ktools/src/owl/src/owl.c	Tue Jun 25 15:51:50 2002
+++ ./owl.c	Wed Jun 26 11:51:47 2002
@@ -96,8 +96,6 @@
   sigaction(SIGALRM, &sigact, NULL);
 
   /* screen init */
-  sprintf(buff, "TERMINFO=%s", TERMINFO);
-  putenv(buff);
   initscr();
   start_color();
   use_default_colors();
diff -u -r /mit/ktools/src/owl/src/tester.c ./tester.c
--- /mit/ktools/src/owl/src/tester.c	Tue Jun 25 15:51:50 2002
+++ ./tester.c	Wed Jun 26 11:52:23 2002
@@ -3,11 +3,6 @@
 #include <stdlib.h>
 
 void screeninit() {
-  char buff[1024];
-  
-  sprintf(buff, "TERMINFO=%s", TERMINFO);
-  putenv(buff);
-
   initscr();
   start_color();
   /* cbreak(); */

home help back first fref pref prev next nref lref last post