[194] in bug-owl
Re: auth patch fix
daemon@ATHENA.MIT.EDU (James M. Kretchmar)
Sun Jun 22 01:31:52 2003
Message-Id: <200306220531.BAA21866@mission-control.mit.edu>
To: Roman Mitz <rmitz@cmu.edu>
cc: bug-owl@MIT.EDU
In-Reply-To: Your message of "Wed, 18 Jun 2003 17:49:41 EDT."
<C44E8B0B-A1D6-11D7-982F-000393C44284@cmu.edu>
Date: Sun, 22 Jun 2003 01:31:51 -0400
From: "James M. Kretchmar" <kretch@MIT.EDU>
> I had assumed that for messages of directions other than in, the
> znotice would be null. That appears to not be the case. I have
> attached a corrected patch. I tested this particular case. :) I'm not
> as happy with the solution, but I figure there are reasons why the
> direction has to be checked. I'd be interested in knowing why my
> assumption (a comment in the previous patch) was invalid...
No particularly good reason, it's just the way I did it at the time.
At the moment owl only lets one send authenticated zephyrs, but in the
future it probably be made to allow unauthenticated sends (since
zwrite does) but certainly should save a copy of the outgoing notice
and auth status either way.
The patch looks fine, though I renamed owl_zephyr_get_auth() to
owl_zephyr_get_authstr().
Thanks,
kretch
