[29717] in bugtraq

home help back first fref pref prev next nref lref last post

Re: AMaViS-ng 0.1.6.x and postfix: possible open relay and mail loss

daemon@ATHENA.MIT.EDU (Phil Cyc)
Thu Apr 10 00:46:46 2003

From: Phil Cyc <ajEA3UMBepQ4MRExDmm0qbFeeQEJtffpg.1@protected.unixadm.org>
To: bugtraq@securityfocus.com
Date: Tue, 8 Apr 2003 23:36:51 +0200
In-Reply-To: <200304071423.47052.ajEA3UMBepQ4MRExDmm0qbFeeQEJtffpg.1@protected.unixadm.org>
MIME-Version: 1.0
Content-Type: Multipart/Mixed;
  boundary="Boundary-00=_zD0k+WUhzg6GRCk"
Message-Id: <200304082336.51237.ajEA3UMBepQ4MRExDmm0qbFeeQEJtffpg.1@protected.unixadm.org>

--Boundary-00=_zD0k+WUhzg6GRCk
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Hi -

As long as the problem is not fixed by the AMaViS-ng maintainers, this patch 
could be helpful.

I took the relevant part from the version 0.1.4.1 source. This patch 
(attachment) applies to 0.1.6.3.

Kind regards,

Phil Cyc

--Boundary-00=_zD0k+WUhzg6GRCk
Content-Type: text/x-diff;
  charset="iso-8859-1";
  name="postfix.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="postfix.patch"

diff -Nru amavis-ng-0.1.6.3.orig/AMAVIS/MTA/Postfix.pm amavis-ng-0.1.6.3.postfix/AMAVIS/MTA/Postfix.pm
--- amavis-ng-0.1.6.3.orig/AMAVIS/MTA/Postfix.pm	Tue Mar 18 00:04:21 2003
+++ amavis-ng-0.1.6.3.postfix/AMAVIS/MTA/Postfix.pm	Tue Apr  8 23:28:09 2003
@@ -112,22 +112,11 @@
 
   writelog($args,LOG_DEBUG, "Called as amavis ".join(' ',@ARGV));
 
-  while (shift @ARGV) {
-    /^-f$/ && next; # ignore "-f"
-    /^-d$/ && next; # ignore "-d"
-    s/^(.*)$/$1/; # untaint sender or recipient
-    if (not defined $$args{'sender'}) {
-      if (/^$/) {
-	$$args{'sender'} = "<>";
-      }
-      else {
-	$$args{'sender'} = $_;
-      }
-    }
-    else {
-      push @{$$args{'recipients'}}, $_;
-    }
-  }
+  shift @ARGV if $ARGV[0] eq "-f";
+  $$args{'sender'} = shift @ARGV;
+  $$args{'sender'} = "<>" if (!$$args{'sender'});
+  shift @ARGV if $ARGV[0] eq "-d";
+  push @{$$args{'recipients'}}, @ARGV;
 
   # Message file has been written, reset file pointer and put it into
   # the record.

--Boundary-00=_zD0k+WUhzg6GRCk--


home help back first fref pref prev next nref lref last post