[15313] in bugtraq
Re: OpenSSH's UseLogin option allows remote access with root
daemon@ATHENA.MIT.EDU (Markus Friedl)
Mon Jun 12 13:27:23 2000
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="pf9I7BMVVzbSWLtt"
Message-Id: <20000612115800.A19359@folly.informatik.uni-erlangen.de>
Date: Mon, 12 Jun 2000 11:58:00 +0200
Reply-To: Markus Friedl <markus.friedl@INFORMATIK.UNI-ERLANGEN.DE>
From: Markus Friedl <markus.friedl@INFORMATIK.UNI-ERLANGEN.DE>
X-To: Phil Stracchino <alaric@BABCOM.COM>
To: BUGTRAQ@SECURITYFOCUS.COM
In-Reply-To: <20000610145425.B14679@babylon5.babcom.com>; from
alaric@BABCOM.COM on Sat, Jun 10, 2000 at 02:54:25PM -0700
--pf9I7BMVVzbSWLtt
Content-Type: text/plain; charset=us-ascii
On Sat, Jun 10, 2000 at 02:54:25PM -0700, Phil Stracchino wrote:
> *** session.c.orig Fri May 19 19:49:31 2000
> --- session.c Fri Jun 9 23:45:28 2000
this is a bad patch, the check for (options.use_login && command
!= NULL) should be compiled into sshd even if USE_PAM is defined.
a correct patch is attached.
moreover, i got some complaints from people who ship OpenSSH and
did not get notified in advance. we don't all who ship OpenSSH,
so please tell me at <markus@openssh.com> if you want to get notified
in the future.
--pf9I7BMVVzbSWLtt
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename=U1
--- session.c-orig Mon Jun 12 11:46:32 2000
+++ session.c Mon Jun 12 11:46:35 2000
@@ -812,6 +812,10 @@
struct stat st;
char *argv[10];
+ /* login(1) is only called if we execute the login shell */
+ if (options.use_login && command != NULL)
+ options.use_login = 0;
+
#ifndef USE_PAM /* pam_nologin handles this */
f = fopen("/etc/nologin", "r");
if (f) {
--pf9I7BMVVzbSWLtt--
