[767] in athena10
Re: Committing com_err support for OS X?
daemon@ATHENA.MIT.EDU (Evan Broder)
Sun Jan 4 17:49:09 2009
Message-ID: <49613CB0.10107@mit.edu>
Date: Sun, 04 Jan 2009 17:48:16 -0500
From: Evan Broder <broder@MIT.EDU>
MIME-Version: 1.0
To: Greg Price <price@mit.edu>
CC: Greg Hudson <ghudson@mit.edu>, athena10@mit.edu
In-Reply-To: <20090104203815.GE3199@vinegar-pot.mit.edu>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Greg Price wrote:
> As a style nitpick, I think "#ifdef __APPLE__" is a better choice than
> "#ifndef __APPLE__" for this reason.
>
I wanted the focus to be on the non-Apple-specific code - that's why I
had that first. The order doesn't really make a difference to me.
Anders Kaseorg wrote:
> Would it be better to define compatibility macros somewhere in an
> appropriate header file?
>
> #ifdef __APPLE__
> # define initialize_del_error_table()
> add_error_table(&et_del_error_table)
> #endif
Not really - as a rule the initialize_foo_error_table() call only
happens once in the source package for a given utility, and is included
as, e.g., the mr_init call for Moira. I don't think you could patch
non-generated code with that #define in a way that's any more efficient
than my suggested patch, and I think it would move the fix away from the
problem, making it harder to see what's going on in the future.
- Evan
