[761] in athena10

home help back first fref pref prev next nref lref last post

Committing com_err support for OS X?

daemon@ATHENA.MIT.EDU (Evan Broder)
Sun Jan 4 02:04:44 2009

Message-ID: <49605F4E.3040707@mit.edu>
Date: Sun, 04 Jan 2009 02:03:42 -0500
From: Evan Broder <broder@MIT.EDU>
MIME-Version: 1.0
To: athena10@mit.edu
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

After banging my head against the wall for a few months, I finally 
figured out why I couldn't get error message lookups with com_err to 
work on MacAthena.

I'd like to commit the necessary patches to the Athena svn repo where 
that's the canonical source. From looking at the repo, that would be 
delete, discuss, libgms, and get_message (I'm not going to bother with 
zephyr, since it's still krb4, and I'll probably submit a patch to 
moiradev later).

The necessary patches are fairly straightforward - here's an example:

Index: athena/bin/delete/delete.c
===================================================================
--- athena/bin/delete/delete.c	(revision 23265)
+++ athena/bin/delete/delete.c	(working copy)
@@ -84,7 +84,11 @@

       whoami = lastpart(argv[0]);

+#ifndef __APPLE__
       initialize_del_error_table();
+#else
+     add_error_table(&et_del_error_table);
+#endif

  #ifdef HAVE_AFS
       gettimeofday(&tvp[0], (struct timezone *)0);

This shouldn't affect the behavior of anything on other Unices, but I 
wanted to check before committing platform-specific code like that for a 
platform that isn't supported.

So, any objections? I'll probably make the necessary commits sometime 
this week if I don't hear otherwise.

- Evan

home help back first fref pref prev next nref lref last post