[286] in athena10

home help back first fref pref prev next nref lref last post

Re: /svn/athena r23051 - in trunk/athena/bin/discuss: client debian libds

daemon@ATHENA.MIT.EDU (Greg Price)
Mon Jun 30 13:11:39 2008

Date: Mon, 30 Jun 2008 13:10:54 -0400
From: Greg Price <price@MIT.EDU>
To: ghudson@mit.edu
Cc: athena10@mit.edu
Message-ID: <20080630171054.GQ5106@vinegar-pot.mit.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200806301651.MAA10669@drugstore.mit.edu>

On Mon, Jun 30, 2008 at 12:51:51PM -0400, ghudson@MIT.EDU wrote:
> --- trunk/athena/bin/discuss/libds/tmem.c	2008-06-30 15:40:09 UTC (rev 23050)
> +++ trunk/athena/bin/discuss/libds/tmem.c	2008-06-30 16:51:50 UTC (rev 23051)
> @@ -75,8 +76,8 @@
>  		return iovmove (SCATTER, (struct iovec **)infop,
>  				argp, argn);
>  	case TFDESTROY:
> -		if (*(char **)info)
> -			free (*(char **)info);
> +		if (*info)
> +			free (*infop);
                     ^^^^          ^

Is this right?

I see there's an 'infop' further up, and I haven't read the actual
file, so for all I know it is.  Seems odd, though.

Greg

home help back first fref pref prev next nref lref last post