[156] in athena10
Re: Quilt patch merging
daemon@ATHENA.MIT.EDU (Greg Hudson)
Mon Apr 7 12:03:59 2008
From: Greg Hudson <ghudson@MIT.EDU>
To: Timothy G Abbott <tabbott@mit.edu>
Cc: athena10@mit.edu, debathena@mit.edu,
Shreevatsa Rajagopalan <vatsa@mit.edu>
In-Reply-To: <Pine.LNX.4.64L.0804061659310.1533@vinegar-pot.mit.edu>
Content-Type: text/plain
Date: Mon, 07 Apr 2008 12:03:01 -0400
Message-Id: <1207584181.5912.35.camel@error-messages.mit.edu>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
On Sun, 2008-04-06 at 18:08 -0400, Timothy G Abbott wrote:
> At the Debathena hackathon today, the quilt patches Debathena has against
> the Athena tree were merged by Shreevatsa Rajagopalan, and I checked them
> in.
I can give vatsa commit access if you're happy with the quality of work
done.
> For liblocker, I think our changes to make
> things run setgid should probably be reviewed by people with more
> liblocker experience than us.
Reviewed, no red flags. I probably would have used chmod instead of
umask, but since I don't think liblocker needs to be thread-safe it
doesn't matter.
> For discuss, someone should probably look over the yacc changes.
It's hard for me to meaningfully review this patch because there's no
information about what it's trying to accomplish. It doesn't look
harmful, at any rate.
> For finger, I'm uncertain what the intended
> behavior was for the zlocate code we removed.
You just removed an error message on zlocate failure. (Which is fine.)
The intent of the overall code there is to display a line line:
On since Wed Jun 20 17:38:17 2007 on :0.0 on host tabbott.mit.edu
in the athena-wide finger information.
