[150] in 6.033-lab
memory leak in html.c
daemon@ATHENA.MIT.EDU (Kevin Fu)
Fri Mar 19 12:23:28 1999
To: 6.033-lab@MIT.EDU
Date: Fri, 19 Mar 1999 12:23:09 EST
From: Kevin Fu <fubob@MIT.EDU>
Just FYI...nobody's perfect. :-)
You are welcome to modify html.c on line 732 at no penalty:
+ xfree(html->head->url);
+ xfree(html->head);
xfree(html);
return;
--------
Kevin E. Fu (fubob@mit.edu)
PGP key: finger fubob@monk.mit.edu
------- Forwarded Message
From: Roger Hu <rogerh@MIT.EDU>
To: 6.033-lab-tas@MIT.EDU
Cc: rogerh@MIT.EDU, stanhu@MIT.EDU
Subject: memory leaks?
Date: Fri, 19 Mar 1999 12:12:22 EST
Along the note of memory leaks, there's a slight one in html_destroy:
void html_destroy(HTML html) {
.
.
.
}
xfree(html);
return;
}
Changed the line to:
void html_destroy(HTML html) {
.
.
.
}
xfree(html->head->url);
xfree(html->head);
xfree(html);
return;
}
We both used http://www.dmalloc.com to track them down. :)
Roger
------- End of Forwarded Message
