[896] in Zephyr_Bugs

home help back first fref pref prev next nref lref last post

bug in tty_filter.c involving alignment and calculating line widths

daemon@ATHENA.MIT.EDU (Greg Stark)
Sun Sep 28 22:43:42 1997

To: bug-zephyr@MIT.EDU
From: Greg Stark <gsstark@MIT.EDU>
Date: 28 Sep 1997 22:43:08 -0400



Hi, I have a bug in tty_filter.c that's been bugging me for a really long
time. I though I had tracked it down a while ago (see txns 706, 707, 708)
but it looks like there is another with similar effects. The effect of the 
bug is that lines are formatted wider than necessary. What appears is
happening is that the tty_filter loop through text doesn't notice some
newlines and includes several lines worth of text in its calculations of line
widths. 

Here is an example of my zephyr format as it is intended to appear:
(the lines are added, there weren't part of zwgc's output)

----------------------------------------------------------------
MESSAGE        white-magic             *.
sender: mhbraun  @s013h009.dialup.unc.edu
time: 20:58:00            Sun Sep 28 1997
             Wind the Frog!
PKA for pika...right? 
----------------------------------------------------------------

The "Wind the Frog!" is the persons zsig and is centered. Notice that the left
justified text below it overlaps the centered text as it should and the entire
zephyr is only as wide as necessary for the widest line.

Now below is a zephyr where it appears the zsig and the first line of the body
are being accumulated as if they were on the same line:

----------------------------------------------------------------
MESSAGE                             white-magic                                   *.
sender: meeroh                                           @THE-FINAL-FRONTIER.MIT.EDU
time: 20:34:32                                                       Sun Sep 28 1997
                                I slept back in July
And then freshmen live _where_?
----------------------------------------------------------------

In this one it's clear that it's only the first line of the body:

----------------------------------------------------------------
MESSAGE                                                          white-magic                                                                *.
sender: brians                                                                                                                 @ISTARI.MIT.EDU
time: 20:31:42                                                                                                                 Sun Sep 28 1997
                                                  "Oh shit.  I'm dead.  That pisses me off."
Current theory from non-residential greeks in EC:
Fiji will be thrown off campus, other frats to follow.
----------------------------------------------------------------

On the other hand in this one it looks like it accumulates the zsig and both
lines of the body. 

----------------------------------------------------------------
MESSAGE                                                                               white-magic                                                                                    *.
sender: anders                                                                                                                                                           @LOCKE.MIT.EDU
time: 20:46:27                                                                                                                                                          Sun Sep 28 1997
                                                                                      Anders Hove
apparently neal dorow appeared to suffer some kind of "breakdown"
at the IFC mtng.  ;)
----------------------------------------------------------------

Here are some more examples:

----------------------------------------------------------------
message                                                     white-magic                                                           *.
sender: mwhitson                                                                                          @ala-ca33-11.ix.netcom.com
time: 20:34:34                                                                                                       Sun Sep 28 1997
                                                          Ladafritt omrede
I don't think Neal Dorow will let that happen.  What marc
said.

MESSAGE                                            white-magic                                                 *.
sender: anders                                                                                     @LOCKE.MIT.EDU
time: 20:49:38                                                                                    Sun Sep 28 1997
                                                   Anders Hove
not a press conference.  reporters not allowed in.

MESSAGE                                      white-magic                                           *.
sender: jemorris                                                                 @CUTTER-JOHN.MIT.EDU
time: 20:57:54                                                                        Sun Sep 28 1997
                         Ph'nglui mglw'nafh Cthulhu R'lyeh wagh'nagl fhtagn!
pika was pi kappa alpha.
----------------------------------------------------------------

home help back first fref pref prev next nref lref last post