[488] in Zephyr_Bugs

home help back first fref pref prev next nref lref last post

bug in server: bdump.c doesn't initialize my_realm

daemon@ATHENA.MIT.EDU (Chris Metcalf)
Sun Jun 13 23:10:51 1993

Date: Sun, 13 Jun 93 23:10:47 -0400
From: metcalf@catfish.LCS.MIT.EDU (Chris Metcalf)
To: zephyr-bugs@Athena.MIT.EDU

I was having difficulties getting our two servers to connect, with 
the only useful error being 'peer not zephyr'.  I augmented the
error message with expected values and found that the server that
was starting up hadn't initialized my_realm yet.  The following
diff moves the call to get_tgt (and consequent initialization of
my_realm) before the test using my_realm.

Chris Metcalf

*** 1.1	1993/06/14 02:57:25
--- bdump.c	1993/06/14 03:04:19
***************
*** 339,358 ****
  	    cleanup(server, omask);
  	    return;
  	}
  	if (strcmp(kdata.pname,ZSRV_SERVICE) ||
  	    strcmp(kdata.pinst, ZSRV_INSTANCE) ||
  	    strcmp(kdata.prealm, my_realm))
  	{
! 	    syslog(LOG_ERR, "bdump_send: peer not zephyr: %s.%s@%s",
! 		   kdata.pname, kdata.pinst,kdata.prealm);
  	    cleanup(server, omask);
  	    return;
  	}
- 	/* authenticate back */
- 	if (get_tgt()) {
- 		cleanup(server, omask);
- 		return;
- 	}
  	if ((retval = SendKerberosData(live_socket, &ticket,
  				       ZSRV_SERVICE, ZSRV_INSTANCE)) != 0) {
  	    syslog(LOG_ERR,"bdump_send: SendKerberosData: %s",
--- 339,360 ----
  	    cleanup(server, omask);
  	    return;
  	}
+ 	/* authenticate back -- must call get_tgt() before using my_realm */
+ 	if (get_tgt()) {
+ 		cleanup(server, omask);
+ 		return;
+ 	}
  	if (strcmp(kdata.pname,ZSRV_SERVICE) ||
  	    strcmp(kdata.pinst, ZSRV_INSTANCE) ||
  	    strcmp(kdata.prealm, my_realm))
  	{
! 	    syslog(LOG_ERR, 
! 		   "bdump_send: peer not zephyr: %s.%s@%s rather than %s.%s@%s",
! 		   kdata.pname, kdata.pinst, kdata.prealm,
! 		   ZSRV_SERVICE, ZSRV_INSTANCE, my_realm);
  	    cleanup(server, omask);
  	    return;
  	}
  	if ((retval = SendKerberosData(live_socket, &ticket,
  				       ZSRV_SERVICE, ZSRV_INSTANCE)) != 0) {
  	    syslog(LOG_ERR,"bdump_send: SendKerberosData: %s",

home help back first fref pref prev next nref lref last post