[923] in Kerberos_V5_Development

home help back first fref pref prev next nref lref last post

Re: decode_krb5_* leak memory on bad packets

daemon@ATHENA.MIT.EDU (Mark W. Eichin)
Wed Sep 13 23:12:56 1995

Date: Wed, 13 Sep 95 23:11:48 -0400
From: "Mark W. Eichin" <eichin@MIT.EDU>
To: tytso@MIT.EDU
Cc: krbdev@MIT.EDU
In-Reply-To: <9509121810.AA14377@dcl.MIT.EDU> (message from Theodore Ts'o on
	Tue, 12 Sep 1995 14:10:28 -0400)

Ok, the decode_krb5_* functions now free things as needed, without
even abusing the macros too much. I'll note that a related problem
occurs in krb5_encode.c, though it isn't as consistent, and needs
checking of every "if (retval) return retval" to see if it needs to
call asn1buf_destroy or not. I'll try to get to that one too
(esp. since this is one that purify will likely never catch -- we test
few enough of the success cases, this would require testing with hard
to arrange error cases) but it'll have to wait a few days at least.

home help back first fref pref prev next nref lref last post