[715] in Kerberos_V5_Development
XXX in lib/krb
jfc@ATHENA.MIT.EDU (jfc@ATHENA.MIT.EDU)
Mon May 20 16:40:06 1991
Common sources of "XXX" comments in lib/krb
1. when writing the replay cache, replay.server is set to "" with a
"XXX" comment.
2. If krb5_rc_store returns an error, the function that called it returns an
error, but the block is marked with XXX.
3. /* XXX we know they are the same size... */
request.nonce = (krb5_int32) time_now;
I don't know the right solution for #1.
#2 should probably remain as-is and the comments deleted. If you're
using a replay cache, you don't want it to fail silently. This may
leave the implementation open to denial of service attacks (e.g.
filling /tmp prevents some programs from running).
#3 should be fixed by defining a function to convert a krb5_timestamp
to a krb5_int32. This can be a simple macro on most UNIX systems.
