[588] in Kerberos_V5_Development

home	help	back	first	fref	pref	prev	next	nref	lref	last	post

Re: switch vs. if

jfc@ATHENA.MIT.EDU (jfc@ATHENA.MIT.EDU)
Tue Jan 29 14:43:08 1991

encode_kdc.c:

    switch (type) {
    case KRB5_AS_REP:
    case KRB5_TGS_REP:
        break;
    default:
        return KRB5_BADMSGTYPE;
    }

should be

    if (type != KRB5_AS_REP && type != KRB5_TGS_REP)
        return KRB5_BADMSGTYPE;


gc_via_tgt.c:

    switch (tgsrep.message_type) {
    case KRB5_TGS_REP:
        break;
    case KRB5_ERROR:
    default:
	[...]
    }

should be

   if (tgsrep.message_type != KRB5_TGS_REP) {
	[...]
   }

get_creds.c:

    switch(retval = krb5_cc_retrieve_cred(ccache, fields, &mcreds, creds)) {
    case KRB5_CC_NOTFOUND:
        break;
    default:
        return retval;
    }

should be

    retval = krb5_cc_retrieve_cred(ccache, fields, &mcreds, creds);
    if (retval != KRB5_CC_NOTFOUND)
	return retval;

rd_req.c:

        switch (retval) {
        case ISODE_50_LOCAL_ERR_BADMSGTYPE:
            return KRB5KRB_AP_ERR_BADVERSION;
        default:
            return(retval);
        }

should be

	if (retval == ISODE_50_LOCAL_ERR_BADMSGTYPE)
		return KRB5KRB_AP_ERR_BADVERSION;
	else
		return retval;

req_req_sim.c has similar code.

home	help	back	first	fref	pref	prev	next	nref	lref	last	post