[2271] in Kerberos_V5_Development
Re: #ifdef unix is wrong afaik
daemon@ATHENA.MIT.EDU (Richard Basch)
Sat Feb 22 09:58:24 1997
Date: Sat, 22 Feb 1997 09:57:24 -0500
To: Sam Hartman <hartmans@MIT.EDU>
Cc: krbdev@MIT.EDU
In-Reply-To: <199702220612.BAA23494@luminous.MIT.EDU>
From: "Richard Basch" <basch@lehman.com>
On Sat, 22-February-1997, "Sam Hartman" wrote to "probe@MIT.EDU, krbdev@MIT.EDU" saying:
> So, at several places in the source tree, you have a #ifdef
> unix; I have always been told that this is the wrong way of doing
> things, and I tend to agree as it is giving me significant trouble at
> the moment. In particular, AIX does not define unix, almost certainly
> because Ansi does not allow it to add to the namespace in this
> manner.
>
> In general, I would do something along the lines of the tests
> in port-socket.h, or if that is inappropriate for some reason, have
> some other define that we arrange to get set. I'm removing all ifdef
> unixes for now, replacing with the moral equivelent of if not
> Windows. If you have a better solution, feel free to implement.
Actually, do not replace it with !WINDOWS... The #ifdef unix is for
backwards compatibility with old Unix comerr. In fact, I would have
preferred to simply #ifdef it on particular platforms. If a platform
doesn't define it, we probably don't even care about the compatibility
on that platform. We don't want it on MacOS, Windows, NT, or any new
platform. I put it in, as #ifdef unix, based on a conversation with Ted.
--
Richard Basch
Sr. Developer/Analyst, DSO URL: http://web.mit.edu/basch/www/home.html
Lehman Brothers, Inc. Email: basch@lehman.com, basch@mit.edu
101 Hudson St., 38th Floor Fax: +1-201-524-5828
Jersey City, NJ 07302-3988 Voice: +1-201-524-5049
