[19226] in Kerberos_V5_Development
C99 VLA (=Variable Lengh Array) helper macros... / was: Re: C99
daemon@ATHENA.MIT.EDU (Roland Mainz)
Thu Jul 9 10:44:40 2015
Date: Thu, 9 Jul 2015 10:44:17 -0400 (EDT)
From: Roland Mainz <rmainz@redhat.com>
To: krbdev@mit.edu
Message-ID: <1875014023.42821736.1436453057576.JavaMail.zimbra@redhat.com>
In-Reply-To: <1393425502.41063220.1436286781140.JavaMail.zimbra@redhat.com>
MIME-Version: 1.0
Content-Type: multipart/mixed;
boundary="----=_Part_42821734_1659394452.1436453057574"
Errors-To: krbdev-bounces@mit.edu
------=_Part_42821734_1659394452.1436453057574
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
----- Original Message -----
> From: "Roland Mainz" <rmainz@redhat.com>
> To: krbdev@mit.edu
> Sent: Tuesday, July 7, 2015 6:33:01 PM
> Subject: Re: C99 Features
>
>
>
> ----- Original Message -----
> > From: "Nathaniel McCallum" <npmccallum@redhat.com>
> > To: krbdev@mit.edu
> > Sent: Tuesday, June 16, 2015 3:06:39 AM
> > Subject: C99 Features
> >
> > It has been 16 years. GCC has had support for many C99 features for a
> > LongTimeNowTM. Clang has had them since the beginning. Clang also now
> > has official Windows builds (as well as many other platforms).
> >
> > Of course, MSVC still lags behind. However, they have started
> > implementing features, including the following since MSVC 2013 [1]:
> > * _Bool
> > * Compound literals
> > * Designated initializers
> > * Mixing declarations with code
> >
> > MS has also implemented most of the C99 libraries[2] and has already
> > announced complete support for the C99 standard library in MSVC
> > 2015[3]. One of the big elephants in the room is VLAs. MS is unlikely
> > to ever support them. But, it is also MS's stated policy to only
> > incorporate C features that are required for C++[4]. I'm not sure that
> > MIT should hold back support for new C features because MS only wants
> > to ship a C++ compiler.
> >
> > So how about it? Can MIT start using C99 features? Even a subset of the
> > features would be helpful. I particularly care about all the above C99
> > features that MS implemented plus VLAs. The latter, in particular, can
> > eliminate a lot of heap allocations.
>
> 1. Using |bool| would be a very good idea because it allows a lot of
> optimizations with low optimizer settings. There is a possible risk of
> namespace clash with |krb5_boolean| so I suggest to use a new define like
> |krb5_std_bool| if we want it in public APIs (which we should do (question
> for myself... did the ISO C spec define a size for |bool| ?))
> 2. IMHO we should use |restrict| where possible (e.g. crypto, string-heavy
> code etc.) to squeeze out some performance
> 3. VLAs can be tricky, but usually aren't a big problem if used with care
> (I've been there with Solaris's OS/Net long ago and it was a *pain*
> politically-wise and getting all tools fixed, but these should be issues if
> the past). Main issue is to define an upper per-allocation limit which can
> be allocated via VLAs and then switch to |malloc()| if the allocation is
> larger than that limit (typically |getpagesize()*8| was considered a "safe"
> limit in Solaris OS/Net). If I recall it correctly the following code should
> handle the issues correctly (except that it should use the ISO C99 feature
> test macros to test whether VLAs are available (this will cover the
> "limitations" of the Microsoft compiler)):
> -- snip --
[snip]
> -- snip --
Attached (as "vla.c.txt") is an updated version which fixes the reported issues:
- Added support to compile with pre-C99 compilers
- Added support for C11 VLA feature test macro |__STDC_NO_VLA__|
- Fix multiple evaluations of the |size| argument in |VLA_ALLOC_ALLOCATE()|
- Make testcase more troublesome for compilers and valgrind
- Add more comments how stuff works
- Attach code instead of pasting it inline to prevent the WebMail software from messing with the code
----
Bye,
Roland
--
__ . . __
(o.\ \/ /.o) rmainz@redhat.com
\__\/\/__/ IPA/Kerberos5 team
/O /==\ O\
(;O/ \/ \O;)
------=_Part_42821734_1659394452.1436453057574
Content-Type: text/plain; name=vla.c.txt
Content-Disposition: attachment; filename=vla.c.txt
Content-Transfer-Encoding: base64
I2luY2x1ZGUgPHN0ZGxpYi5oPgojaW5jbHVkZSA8c3RkaW8uaD4KI2luY2x1ZGUgPHN0cmluZy5o
PgoKLyoKICogVkxBX0FMTE9DX0xJTUlUIC0gZGVmaW5lIHVwcGVyIGxpbWl0IGZvciBWTEEgYWxs
b2NhdGlvbnMKICoKICogVGhpcyBzaG91bGQgYmUgZGVyaXZlZCBmcm9tIHxnZXRwYWdlc2l6ZSgp
fCBidXQgd2UKICogY2FuJ3QgZG8gaXQgZGlyZWN0bHkgaGVyZSBiZWNhdXNlIHxnZXRwYWdlc2l6
ZSgpfCBpcwogKiBhIHN5c2NhbGwgYW5kIHRoZXJlZm9yZSBjYXVzZXMgdG9vIG11Y2ggcGVyLWFs
bG9jYXRpb24KICogb3ZlcmhlYWQKICovCiNkZWZpbmUgVkxBX0FMTE9DX0xJTUlUICg0MDk2Kjgp
CgojaWYgKF9fU1REQ19WRVJTSU9OX18gLSAwID49IDE5OTkwMUwpIC8qIEM5OSAqLyAmJiBcCiAg
ICAoX19TVERDX05PX1ZMQV9fICAtIDAgPCAgMUwpICAgICAgLyogQzExIGZlYXR1cmUgdGVzdCBm
b3IgVkxBIHN1cHBvcnQgKi8KCi8qCiAqIFZMQV9BTExPQ19BTExPQ0FURSAtIGFsbG9jYXRlIGEg
Y2h1bmsgb2YgbWVtb3J5IGZyb20gc3RhY2sKICogaWYgdGhlIHNpemUgaXMgc21hbGxlciB0aGFu
IHxWTEFfQUxMT0NfTElNSVR8IChhbmQgdXNlCiAqIHxtYWxsb2MoKXwgb3RoZXJ3aXNlKSBhbmQg
c3RvcmUgdGhlIHBvaW50ZXIgdG8gdGhhdCBtZW1vcnkKICogaW50byB8ZGVzdHwKICoKICogTm90
ZXM6CiAqIC0gV2Ugc3RpbGwgdXNlIHwxfCBhcyBzaXplIGZvciB0aGUgVkxBIGFycmF5IGlmIHdl
IHVzZSB0aGUKICogfG1hbGxvYygpfCBjb2RlcGF0aCBiZWNhdXNlIHRoZSBJU08gQzFYIHN0YW5k
YXJkIGlzIGEgYml0CiAqIHVuY2xlYXIgaW4gdGhpcyBjb3JuZXIgY2FzZSBhbmQgKFN1biBTdHVk
aW8pIGxpbnQoMSkgY29tcGxhaW5zCiAqIGFib3V0IHplcm8tc2l6ZWQgVkxBIGFycmF5cwogKiAt
IFdlIGRvIG5vdCBwcm92aWRlIGEgY29kZXBhdGggZm9yIHxhbGxvY2EoKXwgYXMgZmFsbGJhY2sK
ICogYmVjYXVzZSB0aGVyZSBhcmUgcGxhdGZvcm1zIHdoaWNoIGRlZmluZSB8YWxsb2NhKCl8IHZp
YSBhCiAqIHdyYXBwZXIgYXJvdW5kIHxtYWxsb2MoKXwgYW5kIHRoZXJlZm9yZSBkbyBub3QgcHJv
dmlkZSBhbnkKICogcGVyZm9ybWFuY2UgYmVuZWZpdHMKICovCiNkZWZpbmUgVkxBX0FMTE9DX0FM
TE9DQVRFKGRlc3QsIG5hbWUsIHNpemUpIFwKCWNvbnN0IHNpemVfdCBtZW1fbWFsbG9jc2l6ZSMj
bmFtZSA9IChzaXplKTsgXAogICAgICAgIHZvaWQgKm1lbV9tYWxsb2MjI25hbWU7IFwKCWNoYXIg
Km1lbV92bGEjI25hbWVbbWVtX21hbGxvY3NpemUjI25hbWUgPiBWTEFfQUxMT0NfTElNSVQ/MToo
bWVtX21hbGxvY3NpemUjI25hbWUpXTsgXAogICAgICAgICgoKG1lbV9tYWxsb2NzaXplIyNuYW1l
KSA+IFZMQV9BTExPQ19MSU1JVCk/IFwKICAgICAgICAgICAgICAgICgoZGVzdCkgPSBtZW1fbWFs
bG9jIyNuYW1lID0gbWFsbG9jKG1lbV9tYWxsb2NzaXplIyNuYW1lKSk6IFwKICAgICAgICAgICAg
ICAgIChtZW1fbWFsbG9jIyNuYW1lID0gTlVMTCwgKGRlc3QpID0gbWVtX3ZsYSMjbmFtZSkpCiNl
bHNlCiNkZWZpbmUgVkxBX0FMTE9DX0FMTE9DQVRFKGRlc3QsIG5hbWUsIHNpemUpIFwKICAgICAg
ICB2b2lkICptZW1fbWFsbG9jIyNuYW1lOyBcCiAgICAgICAgKChkZXN0KSA9IG1lbV9tYWxsb2Mj
I25hbWUgPSBtYWxsb2Moc2l6ZSkpCiNlbmRpZgoKLyoKICogRnJlZSBtZW1vcnkgYWxsb2NhdGVk
IHZpYSB8VkxBX0FMTE9DX0FMTE9DQVRFKCl8CiAqIFBPU0lYIHxmcmVlKCl8IGhhbmRsZXMgTlVM
TC1wb2ludGVycyBhdXRvbWFnaWNhbGx5CiAqLwojZGVmaW5lIFZMQV9BTExPQ19GUkVFKG5hbWUp
IGZyZWUobWVtX21hbGxvYyMjbmFtZSkKCgppbnQgbWFpbihpbnQgYWMsIGNoYXIgKmF2W10pCnsK
ICAgICAgICB2b2lkCSpmcm9nX21lbSwKCQkqZmlzaF9tZW07CiAgICAgICAgc2l6ZV90CWk7CiAg
ICAgICAgCiAgICAgICAgZm9yIChpPTAgOyBpIDwgKChWTEFfQUxMT0NfTElNSVQqNUwpLzRMKSA7
IGkrKykKICAgICAgICB7CiAgICAgICAgICAgICAgICBWTEFfQUxMT0NfQUxMT0NBVEUoZnJvZ19t
ZW0sIGZyb2csIGkpOwoJCWlmIChmcm9nX21lbSkKCQl7CgkJCSh2b2lkKXN0cm5jcHkoZnJvZ19t
ZW0sIAoJCQkJInVzZSBtZW1vcnkgdG8gc3RvcmUgZnJvZyBkYXRhIiwKCQkJCWkpOwoJCX0KCiAg
ICAgICAgICAgICAgICBWTEFfQUxMT0NfQUxMT0NBVEUoZmlzaF9tZW0sIGZpc2gsIGkqMik7CgkJ
aWYgKGZyb2dfbWVtKQoJCXsKCQkJKHZvaWQpc3RybmNweShmaXNoX21lbSwKCQkJCSJ1c2UgbWVt
b3J5IHRvIHN0b3JlIGZpc2ggZGF0YSIsCgkJCQlpKjIpOwoJCX0KCiAgICAgICAgICAgICAgICBW
TEFfQUxMT0NfRlJFRShmcm9nKTsKICAgICAgICAgICAgICAgIFZMQV9BTExPQ19GUkVFKGZpc2gp
OwogICAgICAgIH0KCiAgICAgICAgcmV0dXJuIChFWElUX1NVQ0NFU1MpOwp9Cg==
------=_Part_42821734_1659394452.1436453057574
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
_______________________________________________
krbdev mailing list krbdev@mit.edu
https://mailman.mit.edu/mailman/listinfo/krbdev
------=_Part_42821734_1659394452.1436453057574--
