[18873] in Kerberos_V5_Development
Re: krb5_free_data
daemon@ATHENA.MIT.EDU (Simo Sorce)
Sat Jun 21 13:28:10 2014
Message-ID: <1403371678.19579.9.camel@willson.usersys.redhat.com>
From: Simo Sorce <simo@redhat.com>
To: Markus Moeller <huaraz@moeller.plus.com>
Date: Sat, 21 Jun 2014 13:27:58 -0400
In-Reply-To: <lo4dft$ue3$1@ger.gmane.org>
Mime-Version: 1.0
Cc: krbdev@mit.edu
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: krbdev-bounces@mit.edu
On Sat, 2014-06-21 at 17:56 +0100, Markus Moeller wrote:
> Hi,
>
> I wonder if it wouldn't be better to check if val->data is NULL before
> freeing ?
No, it would be useless, free(NULL); is ok, it is just a no-op.
Simo.
> To me the function makes otherwise no sense as I have to do the
> same checks myself before I can call the function safely.
>
>
> void KRB5_CALLCONV
> krb5_free_data(krb5_context context, krb5_data *val)
> {
> if (val == NULL)
> return;
> free(val->data);
> free(val);
> }
>
>
> Thank you
> Markus
>
>
> _______________________________________________
> krbdev mailing list krbdev@mit.edu
> https://mailman.mit.edu/mailman/listinfo/krbdev
--
Simo Sorce * Red Hat, Inc * New York
_______________________________________________
krbdev mailing list krbdev@mit.edu
https://mailman.mit.edu/mailman/listinfo/krbdev
