[17534] in Kerberos_V5_Development
Commits to krb5-appl
daemon@ATHENA.MIT.EDU (Russ Allbery)
Tue Mar 20 20:58:48 2012
From: Russ Allbery <rra@stanford.edu>
To: krbdev@mit.edu
Date: Tue, 20 Mar 2012 17:58:44 -0700
Message-ID: <8739926a7v.fsf@windlord.stanford.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: krbdev-bounces@mit.edu
Hello folks,
I have a set of fixes for krb5-appl from the Debian package, namely:
Reorder sig_t #define to avoid tromping on system headers
Remove unnecessary include of sys/tty.h that breaks kFreeBSD
Define MAXHOSTNAMELEN in the resolve test to fix builds on Hurd
Fix spelling error in ftp binary
It looks like I have commit access to the krb5-appl repository. Should I
just go ahead and commit these? If so, should I create tickets for them
as well, or just commit?
The second one probably needs some additional explanation. What I
committed for the Debian package is:
diff --git a/telnet/telnetd/sys_term.c b/telnet/telnetd/sys_term.c
index 8d25064..8484fc6 100644
--- a/telnet/telnetd/sys_term.c
+++ b/telnet/telnetd/sys_term.c
@@ -115,9 +115,12 @@ extern struct sysv sysv;
#include <sys/proc.h>
#endif
/* For what platforms do we really need sys/tty.h? */
+/* Not Linux, at least, and including this on kFreeBSD breaks the build. */
+#if 0
#ifdef HAVE_SYS_TTY_H
#include <sys/tty.h>
#endif
+#endif
#ifdef t_erase
#undef t_erase
My inclination is to just remove this code and see if anyone complains.
Any objections? (On kFreeBSD, including sys/tty.h includes
sys/_termios.h, which defines struct termios and conflicts with the glibc
definition of the same struct.)
--
Russ Allbery (rra@stanford.edu) <http://www.eyrie.org/~eagle/>
_______________________________________________
krbdev mailing list krbdev@mit.edu
https://mailman.mit.edu/mailman/listinfo/krbdev
